webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h - Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h

Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixed issues from comments, rewrote MockAudioEncoderHelper Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h ('K') | « webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc ('k') | webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h

diff --git a/webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h b/webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h

index 4f31ecf0fc6e516a352369fa5bc470f9e0c0bee2..52d978dad85c98c78bdef1e97e13eda7229dbbd1 100644

--- a/webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h

+++ b/webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.h

@@ -42,10 +42,6 @@ class AudioEncoderCopyRed final : public AudioEncoder {

size_t Num10MsFramesInNextPacket() const override;

size_t Max10MsFramesInAPacket() const override;

int GetTargetBitrate() const override;

- EncodedInfo EncodeInternal(uint32_t rtp_timestamp,

- rtc::ArrayView<const int16_t> audio,

- size_t max_encoded_bytes,

- uint8_t* encoded) override;

void Reset() override;

bool SetFec(bool enable) override;

bool SetDtx(bool enable) override;

@@ -54,6 +50,11 @@ class AudioEncoderCopyRed final : public AudioEncoder {

void SetProjectedPacketLossRate(double fraction) override;

void SetTargetBitrate(int target_bps) override;

+protected:

+ EncodedInfo EncodeInternal(uint32_t rtp_timestamp,

+ rtc::ArrayView<const int16_t> audio,

+ rtc::Buffer* encoded) override;

private:

AudioEncoder* speech_encoder_;

int red_payload_type_;