webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h - Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixed issues from comments, rewrote MockAudioEncoderHelper Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h ('K') | « webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.cc ('k') | webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

diff --git a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

index 59c8f796eea777b9b94fe65e368c00677d46df84..0711a67e620d13e09154863bbb8c80482e4b35de 100644

--- a/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

+++ b/webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h

@@ -61,11 +61,6 @@ class AudioEncoderOpus final : public AudioEncoder {

size_t Max10MsFramesInAPacket() const override;

int GetTargetBitrate() const override;

- EncodedInfo EncodeInternal(uint32_t rtp_timestamp,

- rtc::ArrayView<const int16_t> audio,

- size_t max_encoded_bytes,

- uint8_t* encoded) override;

void Reset() override;

bool SetFec(bool enable) override;

@@ -84,6 +79,11 @@ class AudioEncoderOpus final : public AudioEncoder {

ApplicationMode application() const { return config_.application; }

bool dtx_enabled() const { return config_.dtx_enabled; }

+protected:

+ EncodedInfo EncodeInternal(uint32_t rtp_timestamp,

+ rtc::ArrayView<const int16_t> audio,

+ rtc::Buffer* encoded) override;

private:

size_t Num10msFramesPerPacket() const;

size_t SamplesPer10msFrame() const;