webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h - Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h

Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixed issues from comments, rewrote MockAudioEncoderHelper Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/codecs/audio_encoder.h ('K') | « webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.cc ('k') | webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t_impl.h » ('j') | webrtc/modules/audio_coding/codecs/mock/mock_audio_encoder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h

diff --git a/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h b/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h

index 321dac3567b64bb96ef7db2bbc7ffd369cf3f685..39b1a9f861f122ecaf6bd6d07ccccffa1e370fcb 100644

--- a/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h

+++ b/webrtc/modules/audio_coding/codecs/isac/audio_encoder_isac_t.h

@@ -62,8 +62,7 @@ class AudioEncoderIsacT final : public AudioEncoder {

int GetTargetBitrate() const override;

EncodedInfo EncodeInternal(uint32_t rtp_timestamp,

rtc::ArrayView<const int16_t> audio,

- size_t max_encoded_bytes,

- uint8_t* encoded) override;

+ rtc::Buffer* encoded) override;

void Reset() override;

private: