Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc

Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed issues from comments, rewrote MockAudioEncoderHelper Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc
diff --git a/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc b/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc
index d7203b9da3ea8b5adb9f1998d285cd0320fbce4d..f33cdde86e0a0d6ccf4104484b62a46334200b8c 100644
--- a/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc
+++ b/webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc
@@ -94,10 +94,7 @@ int AudioEncoderG722::GetTargetBitrate() const {
AudioEncoder::EncodedInfo AudioEncoderG722::EncodeInternal(
uint32_t rtp_timestamp,
rtc::ArrayView<const int16_t> audio,
- size_t max_encoded_bytes,
- uint8_t* encoded) {
- RTC_CHECK_GE(max_encoded_bytes, MaxEncodedBytes());
-
+ rtc::Buffer* encoded) {
if (num_10ms_frames_buffered_ == 0)
first_timestamp_in_buffer_ = rtp_timestamp;
@@ -117,27 +114,33 @@ AudioEncoder::EncodedInfo AudioEncoderG722::EncodeInternal(
num_10ms_frames_buffered_ = 0;
const size_t samples_per_channel = SamplesPerChannel();
for (size_t i = 0; i < num_channels_; ++i) {
- const size_t encoded = WebRtcG722_Encode(
+ const size_t bytes_encoded = WebRtcG722_Encode(
encoders_[i].encoder, encoders_[i].speech_buffer.get(),
samples_per_channel, encoders_[i].encoded_buffer.data());
- RTC_CHECK_EQ(encoded, samples_per_channel / 2);
+ RTC_CHECK_EQ(bytes_encoded, samples_per_channel / 2);
}
- // Interleave the encoded bytes of the different channels. Each separate
- // channel and the interleaved stream encodes two samples per byte, most
- // significant half first.
- for (size_t i = 0; i < samples_per_channel / 2; ++i) {
- for (size_t j = 0; j < num_channels_; ++j) {
- uint8_t two_samples = encoders_[j].encoded_buffer.data()[i];
- interleave_buffer_.data()[j] = two_samples >> 4;
- interleave_buffer_.data()[num_channels_ + j] = two_samples & 0xf;
- }
- for (size_t j = 0; j < num_channels_; ++j)
- encoded[i * num_channels_ + j] = interleave_buffer_.data()[2 * j] << 4 |
- interleave_buffer_.data()[2 * j + 1];
- }
+ const size_t bytes_to_encode = samples_per_channel / 2 * num_channels_;
EncodedInfo info;
- info.encoded_bytes = samples_per_channel / 2 * num_channels_;
+ info.encoded_bytes = encoded->AppendData(
+ bytes_to_encode, [&] (rtc::ArrayView<uint8_t> encoded) {
+ // Interleave the encoded bytes of the different channels. Each separate
+ // channel and the interleaved stream encodes two samples per byte, most
+ // significant half first.
+ for (size_t i = 0; i < samples_per_channel / 2; ++i) {
+ for (size_t j = 0; j < num_channels_; ++j) {
+ uint8_t two_samples = encoders_[j].encoded_buffer.data()[i];
+ interleave_buffer_.data()[j] = two_samples >> 4;
+ interleave_buffer_.data()[num_channels_ + j] = two_samples & 0xf;
+ }
+ for (size_t j = 0; j < num_channels_; ++j)
+ encoded[i * num_channels_ + j] =
+ interleave_buffer_.data()[2 * j] << 4 |
+ interleave_buffer_.data()[2 * j + 1];
+ }
+
+ return bytes_to_encode;
+ });
info.encoded_timestamp = first_timestamp_in_buffer_;
info.payload_type = payload_type_;
return info;

Powered by Google App Engine
This is Rietveld 408576698