webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h - Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h

Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Reverted unnecessary change to buffer_unittest.cc Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/codecs/audio_encoder_unittest.cc ('K') | « webrtc/modules/audio_coding/codecs/audio_encoder_unittest.cc ('k') | webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc » ('j') | webrtc/modules/audio_coding/codecs/g711/audio_encoder_pcm.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h

diff --git a/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h b/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h

index 8a17ac9822c189b7a1a3b08dc50d1f53be87b624..7ae6eb9b182e403739becdf7a425dbd78a6f58ea 100644

--- a/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h

+++ b/webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.h

@@ -59,8 +59,7 @@ class AudioEncoderCng final : public AudioEncoder {

int GetTargetBitrate() const override;

EncodedInfo EncodeInternal(uint32_t rtp_timestamp,

rtc::ArrayView<const int16_t> audio,

- size_t max_encoded_bytes,

- uint8_t* encoded) override;

+ rtc::Buffer* encoded) override;

void Reset() override;

bool SetFec(bool enable) override;

bool SetDtx(bool enable) override;

@@ -71,11 +70,9 @@ class AudioEncoderCng final : public AudioEncoder {

private:

EncodedInfo EncodePassive(size_t frames_to_encode,

- size_t max_encoded_bytes,

- uint8_t* encoded);

+ rtc::Buffer* encoded);

EncodedInfo EncodeActive(size_t frames_to_encode,

- size_t max_encoded_bytes,

- uint8_t* encoded);

+ rtc::Buffer* encoded);

size_t SamplesPer10msFrame() const;

AudioEncoder* speech_encoder_;