webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h - Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h

Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Added more fixes for override hiding in AudioEncoder implementations. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc ('K') | « webrtc/modules/audio_coding/neteq/test/neteq_pcmu_quality_test.cc ('k') | webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h

diff --git a/webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h b/webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h

index 8bae160476149c2227f1422c90304c03459a0fd5..43c95b80625e5d7949c04998e116884f338ab316 100644

--- a/webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h

+++ b/webrtc/modules/audio_coding/neteq/tools/neteq_quality_test.h

@@ -77,7 +77,7 @@ class NetEqQualityTest : public ::testing::Test {

// 2. save the bit stream to |payload| of |max_bytes| bytes in size,

// 3. returns the length of the payload (in bytes),

virtual int EncodeBlock(int16_t* in_data, size_t block_size_samples,

- uint8_t* payload, size_t max_bytes) = 0;

+ rtc::Buffer* payload, size_t max_bytes) = 0;

// PacketLost(...) determines weather a packet sent at an indicated time gets

// lost or not.

@@ -128,7 +128,7 @@ class NetEqQualityTest : public ::testing::Test {

std::unique_ptr<LossModel> loss_model_;

std::unique_ptr<int16_t[]> in_data_;

- std::unique_ptr<uint8_t[]> payload_;

+ rtc::Buffer payload_;

std::unique_ptr<int16_t[]> out_data_;

WebRtcRTPHeader rtp_header_;