webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h - Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h

Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Added more fixes for override hiding in AudioEncoder implementations. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc ('K') | « webrtc/modules/audio_coding/codecs/g722/audio_encoder_g722.cc ('k') | webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h

diff --git a/webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h b/webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h

index 7b6c075f0a38dd27d61cfe693bdcbf87dbb39f0f..e0ba289d766aa85e7179ea3c187576138c5b7585 100644

--- a/webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h

+++ b/webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h

@@ -21,6 +21,8 @@ struct CodecInst;

class AudioEncoderIlbc final : public AudioEncoder {

public:

+ using AudioEncoder::EncodeInternal;

struct Config {

bool IsOk() const;

@@ -42,8 +44,7 @@ class AudioEncoderIlbc final : public AudioEncoder {

int GetTargetBitrate() const override;

EncodedInfo EncodeInternal(uint32_t rtp_timestamp,

rtc::ArrayView<const int16_t> audio,

- size_t max_encoded_bytes,

- uint8_t* encoded) override;

+ rtc::Buffer* encoded) override;

void Reset() override;

private: