Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Side by Side Diff: webrtc/modules/audio_coding/codecs/ilbc/audio_encoder_ilbc.h

Issue 1725143003: Changed AudioEncoder::Encode to take an rtc::Buffer* instead of uint8_t* and a maximum size. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixed issues from comments, rewrote MockAudioEncoderHelper Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 24 matching lines...) Expand all
35 ~AudioEncoderIlbc() override; 35 ~AudioEncoderIlbc() override;
36 36
37 size_t MaxEncodedBytes() const override; 37 size_t MaxEncodedBytes() const override;
38 int SampleRateHz() const override; 38 int SampleRateHz() const override;
39 size_t NumChannels() const override; 39 size_t NumChannels() const override;
40 size_t Num10MsFramesInNextPacket() const override; 40 size_t Num10MsFramesInNextPacket() const override;
41 size_t Max10MsFramesInAPacket() const override; 41 size_t Max10MsFramesInAPacket() const override;
42 int GetTargetBitrate() const override; 42 int GetTargetBitrate() const override;
43 EncodedInfo EncodeInternal(uint32_t rtp_timestamp, 43 EncodedInfo EncodeInternal(uint32_t rtp_timestamp,
44 rtc::ArrayView<const int16_t> audio, 44 rtc::ArrayView<const int16_t> audio,
45 size_t max_encoded_bytes, 45 rtc::Buffer* encoded) override;
46 uint8_t* encoded) override;
47 void Reset() override; 46 void Reset() override;
48 47
49 private: 48 private:
50 size_t RequiredOutputSizeBytes() const; 49 size_t RequiredOutputSizeBytes() const;
51 50
52 static const size_t kMaxSamplesPerPacket = 480; 51 static const size_t kMaxSamplesPerPacket = 480;
53 const Config config_; 52 const Config config_;
54 const size_t num_10ms_frames_per_packet_; 53 const size_t num_10ms_frames_per_packet_;
55 size_t num_10ms_frames_buffered_; 54 size_t num_10ms_frames_buffered_;
56 uint32_t first_timestamp_in_buffer_; 55 uint32_t first_timestamp_in_buffer_;
57 int16_t input_buffer_[kMaxSamplesPerPacket]; 56 int16_t input_buffer_[kMaxSamplesPerPacket];
58 IlbcEncoderInstance* encoder_; 57 IlbcEncoderInstance* encoder_;
59 RTC_DISALLOW_COPY_AND_ASSIGN(AudioEncoderIlbc); 58 RTC_DISALLOW_COPY_AND_ASSIGN(AudioEncoderIlbc);
60 }; 59 };
61 60
62 } // namespace webrtc 61 } // namespace webrtc
63 #endif // WEBRTC_MODULES_AUDIO_CODING_CODECS_ILBC_AUDIO_ENCODER_ILBC_H_ 62 #endif // WEBRTC_MODULES_AUDIO_CODING_CODECS_ILBC_AUDIO_ENCODER_ILBC_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698