Chromium Code Reviews

Issue 1724303005: Make pbos owner of additional video files. (Closed)

Created:
4 years, 10 months ago by nisse-webrtc
Modified:
4 years, 10 months ago
Reviewers:
tommi, pbos-webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make pbos owner of additional video files. NOTRY=True Committed: https://crrev.com/e31dc950844cf7bc396db1c76ceec9093931e7cc Cr-Commit-Position: refs/heads/master@{#11781}

Patch Set 1 #

Patch Set 2 : More fine-grained OWNERShip. #

Unified diffs Side-by-side diffs Stats (+3 lines, -0 lines)
M webrtc/OWNERS View 1 chunk +2 lines, -0 lines 0 comments
M webrtc/common_video/OWNERS View 1 chunk +1 line, -0 lines 0 comments

Messages

Total messages: 16 (8 generated)
nisse-webrtc
Makes pbos a root owner. (I could have added him to webrtc/OWNERS instead, which is ...
4 years, 10 months ago (2016-02-25 11:52:34 UTC) #2
nisse-webrtc
New version with more fine-grained ownership.
4 years, 10 months ago (2016-02-25 13:58:13 UTC) #4
tommi
lgtm
4 years, 10 months ago (2016-02-26 10:16:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724303005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724303005/20001
4 years, 10 months ago (2016-02-26 10:16:17 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 10 months ago (2016-02-26 12:16:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1724303005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1724303005/20001
4 years, 10 months ago (2016-02-26 12:24:34 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-26 12:29:14 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-02-26 12:29:26 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e31dc950844cf7bc396db1c76ceec9093931e7cc
Cr-Commit-Position: refs/heads/master@{#11781}

Powered by Google App Engine