Chromium Code Reviews

Issue 1723163002: Adds low complexity audio mode for single core CPUs (Closed)

Created:
4 years, 10 months ago by henrika_webrtc
Modified:
4 years, 10 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adds low complexity audio mode for single core CPUs BUG=webrtc:5538 R=tkchin@webrtc.org Committed: https://crrev.com/3e60bf0ff3b0cb1d5a5418f41218fd86c462e420 Cr-Commit-Position: refs/heads/master@{#11743}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Stats (+136 lines, -93 lines)
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 7 chunks +37 lines, -8 lines 0 comments
M webrtc/modules/utility/include/helpers_ios.h View 1 chunk +17 lines, -0 lines 0 comments
M webrtc/modules/utility/source/helpers_ios.mm View 2 chunks +82 lines, -85 lines 2 comments

Messages

Total messages: 12 (5 generated)
henrika_webrtc
Zeke, please read the bug description for a background description. In short, we now use ...
4 years, 10 months ago (2016-02-23 15:09:04 UTC) #3
tkchin_webrtc
lgtm % latest comment from silviu https://codereview.webrtc.org/1723163002/diff/1/webrtc/modules/utility/source/helpers_ios.mm File webrtc/modules/utility/source/helpers_ios.mm (right): https://codereview.webrtc.org/1723163002/diff/1/webrtc/modules/utility/source/helpers_ios.mm#newcode154 webrtc/modules/utility/source/helpers_ios.mm:154: NSString* processName = ...
4 years, 10 months ago (2016-02-23 17:39:27 UTC) #4
henrika_webrtc
https://codereview.webrtc.org/1723163002/diff/1/webrtc/modules/utility/source/helpers_ios.mm File webrtc/modules/utility/source/helpers_ios.mm (right): https://codereview.webrtc.org/1723163002/diff/1/webrtc/modules/utility/source/helpers_ios.mm#newcode154 webrtc/modules/utility/source/helpers_ios.mm:154: NSString* processName = [NSProcessInfo processInfo].processName; Filed https://bugs.chromium.org/p/webrtc/issues/detail?id=5582.
4 years, 10 months ago (2016-02-24 11:52:48 UTC) #5
henrika_webrtc
Landing as is since I am unable to reproduce the final issue mentioned by Silviu. ...
4 years, 10 months ago (2016-02-24 12:24:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723163002/1
4 years, 10 months ago (2016-02-24 12:24:54 UTC) #8
henrika_webrtc
Committed patchset #1 (id:1) manually as 3e60bf0ff3b0cb1d5a5418f41218fd86c462e420 (presubmit successful).
4 years, 10 months ago (2016-02-24 13:27:28 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 13:27:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3e60bf0ff3b0cb1d5a5418f41218fd86c462e420
Cr-Commit-Position: refs/heads/master@{#11743}

Powered by Google App Engine