Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1723153002: Remove the VoEDtmf interface. (Closed)

Created:
4 years, 10 months ago by the sun
Modified:
4 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, rwolff_gocast.it, yujie_mao (webrtc), Andrew MacDonald, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the VoEDtmf interface. BUG=webrtc:4690 Committed: https://crrev.com/622d8950f594574bf9721496b99fc9a30d8a54bf Cr-Commit-Position: refs/heads/master@{#11906}

Patch Set 1 #

Patch Set 2 : more remove #

Patch Set 3 : rebase #

Total comments: 4

Patch Set 4 : using unique_ptr instead #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -461 lines) Patch
M webrtc/engine_configurations.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/mock_voice_engine.h View 1 chunk +0 lines, -16 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D webrtc/voice_engine/include/voe_dtmf.h View 1 chunk +0 lines, -92 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/after_streaming_fixture.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/after_streaming_fixture.cc View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/standard/dtmf_test.cc View 1 2 3 2 chunks +8 lines, -28 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.h View 6 chunks +1 line, -10 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.cc View 5 chunks +0 lines, -10 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_test_defines.h View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc View 4 chunks +0 lines, -6 lines 0 comments Download
D webrtc/voice_engine/voe_dtmf_impl.h View 1 chunk +0 lines, -53 lines 0 comments Download
D webrtc/voice_engine/voe_dtmf_impl.cc View 1 chunk +0 lines, -217 lines 0 comments Download
M webrtc/voice_engine/voice_engine.gyp View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M webrtc/voice_engine/voice_engine_impl.h View 3 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
the sun
4 years, 10 months ago (2016-02-23 15:40:07 UTC) #2
henrika_webrtc
Drive by: LGTM ;-)
4 years, 9 months ago (2016-02-24 08:38:03 UTC) #5
tlegrand-webrtc
lgtm
4 years, 9 months ago (2016-02-24 09:33:35 UTC) #6
tlegrand-webrtc
lgtm
4 years, 9 months ago (2016-02-24 09:33:36 UTC) #7
the sun
hlundin@, PTAL?
4 years, 9 months ago (2016-03-07 09:18:51 UTC) #8
hlundin-webrtc
LGTM with nits. https://codereview.webrtc.org/1723153002/diff/40001/webrtc/voice_engine/test/auto_test/fixtures/after_streaming_fixture.h File webrtc/voice_engine/test/auto_test/fixtures/after_streaming_fixture.h (right): https://codereview.webrtc.org/1723153002/diff/40001/webrtc/voice_engine/test/auto_test/fixtures/after_streaming_fixture.h#newcode16 webrtc/voice_engine/test/auto_test/fixtures/after_streaming_fixture.h:16: #include "webrtc/voice_engine/channel_proxy.h" Order of includes... https://codereview.webrtc.org/1723153002/diff/40001/webrtc/voice_engine/test/auto_test/standard/dtmf_test.cc ...
4 years, 9 months ago (2016-03-07 15:59:23 UTC) #9
the sun
https://codereview.webrtc.org/1723153002/diff/40001/webrtc/voice_engine/test/auto_test/fixtures/after_streaming_fixture.h File webrtc/voice_engine/test/auto_test/fixtures/after_streaming_fixture.h (right): https://codereview.webrtc.org/1723153002/diff/40001/webrtc/voice_engine/test/auto_test/fixtures/after_streaming_fixture.h#newcode16 webrtc/voice_engine/test/auto_test/fixtures/after_streaming_fixture.h:16: #include "webrtc/voice_engine/channel_proxy.h" On 2016/03/07 15:59:22, hlundin-webrtc wrote: > Order ...
4 years, 9 months ago (2016-03-07 16:11:36 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723153002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723153002/60001
4 years, 9 months ago (2016-03-07 16:23:43 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-07 18:24:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1723153002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1723153002/80001
4 years, 9 months ago (2016-03-08 10:19:21 UTC) #17
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 9 months ago (2016-03-08 12:10:56 UTC) #19
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 12:11:14 UTC) #21
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/622d8950f594574bf9721496b99fc9a30d8a54bf
Cr-Commit-Position: refs/heads/master@{#11906}

Powered by Google App Engine
This is Rietveld 408576698