Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1722523002: iOS: Don't run modules_unittests on iOS simulator (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS: Don't run modules_unittests on iOS simulator This is the only failing test of the currently deployed at the iOS Simulator bots. Let's disable it so we can promote the passing tests to the main waterfall and the trybots. BUG=webrtc:4755 TBR=henrika@webrtc.org Committed: https://crrev.com/ada8fe5c004c720c89926b2a93d1608b09b47c4b Cr-Commit-Position: refs/heads/master@{#11703}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M webrtc/build/ios/tests/common_tests.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kjellander_webrtc
4 years, 10 months ago (2016-02-22 06:34:05 UTC) #1
kjellander_webrtc
Committed patchset #1 (id:1) manually as ada8fe5c004c720c89926b2a93d1608b09b47c4b (presubmit successful).
4 years, 10 months ago (2016-02-22 06:34:45 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ada8fe5c004c720c89926b2a93d1608b09b47c4b Cr-Commit-Position: refs/heads/master@{#11703}
4 years, 10 months ago (2016-02-22 06:34:47 UTC) #5
henrika_webrtc
4 years, 10 months ago (2016-02-22 09:10:16 UTC) #6
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698