Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2140)

Issue 1722083002: Replace scoped_ptr with unique_ptr in webrtc/modules/audio_device/ (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 10 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/modules/audio_device/ BUG=webrtc:5520 Committed: https://crrev.com/f01633e66792cdbb7da06ff7949ac466d98d96e6 Cr-Commit-Position: refs/heads/master@{#11740}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -90 lines) Patch
M webrtc/modules/audio_device/android/audio_device_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_manager.h View 4 chunks +7 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_manager.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_manager_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_record_jni.h View 4 chunks +7 lines, -5 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_record_jni.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_track_jni.h View 4 chunks +7 lines, -5 lines 0 comments Download
M webrtc/modules/audio_device/android/audio_track_jni.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M webrtc/modules/audio_device/android/build_info.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/android/build_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_device/android/opensles_player.h View 3 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_device/audio_device_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/dummy/file_audio_device.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/fine_audio_buffer.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_device/fine_audio_buffer_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.h View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_unittest_ios.cc View 8 chunks +7 lines, -7 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_alsa_linux.h View 2 chunks +4 lines, -2 lines 0 comments Download
M webrtc/modules/audio_device/linux/audio_device_pulse_linux.h View 2 chunks +5 lines, -3 lines 0 comments Download
M webrtc/modules/audio_device/mac/audio_device_mac.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/modules/audio_device/test/audio_device_test_api.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M webrtc/modules/audio_device/test/func_test_manager.h View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/modules/audio_device/test/func_test_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_device/win/audio_device_wave_win.h View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
kwiberg-webrtc
4 years, 10 months ago (2016-02-24 10:55:58 UTC) #5
henrika_webrtc
I am sure this is for a good cause and part of a larger effort, ...
4 years, 10 months ago (2016-02-24 10:59:50 UTC) #6
kwiberg-webrtc
On 2016/02/24 10:59:50, henrika_webrtc wrote: > I am sure this is for a good cause ...
4 years, 10 months ago (2016-02-24 12:04:30 UTC) #7
henrika_webrtc
Thanks and LGTM. I will use std::uniqe_ptr in the future then.
4 years, 10 months ago (2016-02-24 12:06:51 UTC) #8
kwiberg-webrtc
On 2016/02/24 12:06:51, henrika_webrtc wrote: > Thanks and LGTM. I will use std::uniqe_ptr in the ...
4 years, 10 months ago (2016-02-24 12:12:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1722083002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1722083002/60001
4 years, 10 months ago (2016-02-24 12:12:20 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:60001)
4 years, 10 months ago (2016-02-24 13:00:41 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 13:00:51 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f01633e66792cdbb7da06ff7949ac466d98d96e6
Cr-Commit-Position: refs/heads/master@{#11740}

Powered by Google App Engine
This is Rietveld 408576698