Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1720353002: Roll chromium_revision aa04eb9..4d6ba6e (376768:376909) (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
tkchin_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Roll chromium_revision aa04eb9..4d6ba6e (376768:376909) Add build_overrides/build.gni similar to https://codereview.chromium.org/1686373002 in order for us to have some targets generated only for WebRTC. Change log: https://chromium.googlesource.com/chromium/src/+log/aa04eb9..4d6ba6e Full diff: https://chromium.googlesource.com/chromium/src/+/aa04eb9..4d6ba6e Changed dependencies: * src/buildtools: https://chromium.googlesource.com/chromium/buildtools.git/+log/ef3e530..97b5c48 DEPS diff: https://chromium.googlesource.com/chromium/src/+/aa04eb9..4d6ba6e/DEPS No update to Clang. TBR=tkchin@webrtc.org BUG=webrtc:5453 Committed: https://crrev.com/0be9df429349d0582380bddf534848b7468da0ff Cr-Commit-Position: refs/heads/master@{#11715}

Patch Set 1 #

Patch Set 2 : Added build_overrides/build.gni #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
A build_overrides/build.gni View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720353002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720353002/1
4 years, 10 months ago (2016-02-23 03:04:48 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: mac_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/7228)
4 years, 10 months ago (2016-02-23 03:07:31 UTC) #4
kjellander_webrtc
4 years, 10 months ago (2016-02-23 06:18:37 UTC) #8
kjellander_webrtc
Committed patchset #2 (id:20001) manually as 0be9df429349d0582380bddf534848b7468da0ff (presubmit successful).
4 years, 10 months ago (2016-02-23 06:19:12 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0be9df429349d0582380bddf534848b7468da0ff Cr-Commit-Position: refs/heads/master@{#11715}
4 years, 10 months ago (2016-02-23 06:19:16 UTC) #12
tkchin_webrtc
4 years, 10 months ago (2016-02-23 17:15:37 UTC) #13
Message was sent while issue was closed.
On 2016/02/23 06:19:16, commit-bot: I haz the power wrote:
> Patchset 2 (id:??) landed as
> https://crrev.com/0be9df429349d0582380bddf534848b7468da0ff
> Cr-Commit-Position: refs/heads/master@{#11715}

lgtm

Powered by Google App Engine
This is Rietveld 408576698