Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Issue 1720283002: Add more camera resolutions to camera scaling slider. (Closed)

Created:
4 years, 10 months ago by AlexG
Modified:
4 years, 10 months ago
Reviewers:
wzh
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add more camera resolutions to camera scaling slider. Plus allow to use loopback adapter in loopback call. BUG=b/26287075 R=wzh@webrtc.org Committed: https://crrev.com/dc0e381eb59b61218b2649c77a3cddc0bb83f5d6 Cr-Commit-Position: refs/heads/master@{#11714}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M webrtc/examples/androidapp/src/org/appspot/apprtc/CallActivity.java View 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/CaptureQualityController.java View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
AlexG
PTAL
4 years, 10 months ago (2016-02-22 23:50:41 UTC) #2
wzh
lgtm
4 years, 10 months ago (2016-02-22 23:59:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720283002/1
4 years, 10 months ago (2016-02-23 00:11:34 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_arm64_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/7659) ios_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 10 months ago (2016-02-23 00:12:30 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1720283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1720283002/1
4 years, 10 months ago (2016-02-23 00:16:27 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_arm64_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/7660) ios_rel on ...
4 years, 10 months ago (2016-02-23 00:17:21 UTC) #11
AlexG
Committed patchset #1 (id:1) manually as dc0e381eb59b61218b2649c77a3cddc0bb83f5d6 (presubmit successful).
4 years, 10 months ago (2016-02-23 00:48:40 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 00:48:43 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc0e381eb59b61218b2649c77a3cddc0bb83f5d6
Cr-Commit-Position: refs/heads/master@{#11714}

Powered by Google App Engine
This is Rietveld 408576698