Move congestion controller to a separate module.

Move congestion controller to a separate module.

This allows other projects to more easily depend on this.

The plan is to move remote_bitrate_estimator and bitrate_controller into this module and reduce the exposed interface to only a simplified version of congestion_controller.h.

No functional changes in this CL.

R=mflodman@webrtc.org, pbos@webrtc.org

Committed: https://crrev.com/80e12072cf9667ca25d9edf3b9e8d926dbe2f50c
Cr-Commit-Position: refs/heads/master@{#11718}

[stefan-webrtc, 2016-02-19 10:13:56]

Add gypi and gn files.

[stefan-webrtc, 2016-02-19 10:22:39]

Fix gn

[stefan-webrtc, 2016-02-19 10:24:30]

stefan@webrtc.org changed reviewers:
+ mflodman@webrtc.org

[stefan-webrtc, 2016-02-19 10:24:54]

Description was changed from

==========
Move congestion controller to a separate module.

This allows other projects to more easily depend on this.

The plan is to move remote_bitrate_estimator and bitrate_controller into this
module and reduce the exposed interface to only a simplified version of
congestion_controller.h.
==========

to

==========
Move congestion controller to a separate module.

This allows other projects to more easily depend on this.

The plan is to move remote_bitrate_estimator and bitrate_controller into this
module and reduce the exposed interface to only a simplified version of
congestion_controller.h.

No functional changes in this CL.
==========

[pbos-webrtc, 2016-02-19 13:39:04]

pbos@webrtc.org changed reviewers:
+ pbos@webrtc.org

[pbos-webrtc, 2016-02-19 13:39:04]

lgtm, I'd prefer mock/ over include/mock/ we can still make mock/ part of the
presubmit

Also I think you should add congestion_controller/include (and mock/) to the
presubmit check

https://codereview.webrtc.org/1718473002/diff/40001/webrtc/audio/audio_receiv...
File webrtc/audio/audio_receive_stream_unittest.cc (right):

https://codereview.webrtc.org/1718473002/diff/40001/webrtc/audio/audio_receiv...
webrtc/audio/audio_receive_stream_unittest.cc:19: #include
"webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h"
maybe change include/mock to mock here?

https://codereview.webrtc.org/1718473002/diff/40001/webrtc/modules/congestion...
File
webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h
(right):

https://codereview.webrtc.org/1718473002/diff/40001/webrtc/modules/congestion...
webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h:11:
#ifndef
WEBRTC_MODULES_CONGESTION_CONTROLLER_INCLUDE_MOCK_MOCK_CONGESTION_CONTROLLER_H_
if you move this file then remove _INCLUDE

[mflodman, 2016-02-23 10:34:40]

LGTM

For the record:
This breaks the assumption on modules not depending on each other, but this is
ok since the intention is to follow up by moving bitrate controller and
bandwidth estimator to the new target/module.

[stefan-webrtc, 2016-02-23 10:36:01]

On 2016/02/23 10:34:40, mflodman wrote:
> LGTM
> 
> For the record:
> This breaks the assumption on modules not depending on each other, but this is
> ok since the intention is to follow up by moving bitrate controller and
> bandwidth estimator to the new target/module.

Yes. We'll work on resolving this as part of other refactoring work we've
planned.

[stefan-webrtc, 2016-02-23 10:52:30]

Add presubmit

[stefan-webrtc, 2016-02-23 10:53:36]

Added presubmits. Won't move the mock since it's in line with where most of the
mocks are placed in the codebase.

[stefan-webrtc, 2016-02-23 10:54:02]

The CQ bit was checked by stefan@webrtc.org

[stefan-webrtc, 2016-02-23 10:54:02]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org,
mflodman@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1718473002/#ps60001 (title:
"Add presubmit")

[commit-bot: I haz the power, 2016-02-23 10:54:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1718473002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1718473002/60001

[stefan-webrtc, 2016-02-23 12:30:56]

Description was changed from

==========
Move congestion controller to a separate module.

This allows other projects to more easily depend on this.

The plan is to move remote_bitrate_estimator and bitrate_controller into this
module and reduce the exposed interface to only a simplified version of
congestion_controller.h.

No functional changes in this CL.
==========

to

==========
Move congestion controller to a separate module.

This allows other projects to more easily depend on this.

The plan is to move remote_bitrate_estimator and bitrate_controller into this
module and reduce the exposed interface to only a simplified version of
congestion_controller.h.

No functional changes in this CL.

R=mflodman@webrtc.org, pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/80e12072cf9667ca25d9edf3b...
==========

[commit-bot: I haz the power, 2016-02-23 12:30:57]

Description was changed from

==========
Move congestion controller to a separate module.

This allows other projects to more easily depend on this.

The plan is to move remote_bitrate_estimator and bitrate_controller into this
module and reduce the exposed interface to only a simplified version of
congestion_controller.h.

No functional changes in this CL.

R=mflodman@webrtc.org, pbos@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/80e12072cf9667ca25d9edf3b...
==========

to

==========
Move congestion controller to a separate module.

This allows other projects to more easily depend on this.

The plan is to move remote_bitrate_estimator and bitrate_controller into this
module and reduce the exposed interface to only a simplified version of
congestion_controller.h.

No functional changes in this CL.

R=mflodman@webrtc.org, pbos@webrtc.org

Committed: https://crrev.com/80e12072cf9667ca25d9edf3b9e8d926dbe2f50c
Cr-Commit-Position: refs/heads/master@{#11718}
==========

[stefan-webrtc, 2016-02-23 12:30:57]

Committed patchset #4 (id:60001) manually as
80e12072cf9667ca25d9edf3b9e8d926dbe2f50c (presubmit successful).

[commit-bot: I haz the power, 2016-02-23 12:30:57]

Patchset 4 (id:??) landed as
https://crrev.com/80e12072cf9667ca25d9edf3b9e8d926dbe2f50c
Cr-Commit-Position: refs/heads/master@{#11718}