Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(843)

Issue 1718473002: Move congestion controller to a separate module. (Closed)

Created:
4 years, 10 months ago by stefan-webrtc
Modified:
4 years, 10 months ago
Reviewers:
pbos-webrtc, mflodman
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, tlegrand-webrtc, tterriberry_mozilla.com, andresp, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move congestion controller to a separate module. This allows other projects to more easily depend on this. The plan is to move remote_bitrate_estimator and bitrate_controller into this module and reduce the exposed interface to only a simplified version of congestion_controller.h. No functional changes in this CL. R=mflodman@webrtc.org, pbos@webrtc.org Committed: https://crrev.com/80e12072cf9667ca25d9edf3b9e8d926dbe2f50c Cr-Commit-Position: refs/heads/master@{#11718}

Patch Set 1 #

Patch Set 2 : Add gypi and gn files. #

Patch Set 3 : Fix gn #

Total comments: 2

Patch Set 4 : Add presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -428 lines) Patch
M PRESUBMIT.py View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/audio/audio_receive_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_receive_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_send_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/audio/audio_send_stream_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/call/BUILD.gn View 1 2 2 chunks +1 line, -1 line 0 comments Download
M webrtc/call/call.cc View 1 chunk +1 line, -1 line 0 comments Download
D webrtc/call/congestion_controller.h View 1 chunk +0 lines, -87 lines 0 comments Download
D webrtc/call/congestion_controller.cc View 1 chunk +0 lines, -257 lines 0 comments Download
D webrtc/call/mock/mock_congestion_controller.h View 1 chunk +0 lines, -51 lines 0 comments Download
M webrtc/call/webrtc_call.gypi View 2 chunks +1 line, -1 line 0 comments Download
A + webrtc/modules/congestion_controller/BUILD.gn View 1 2 chunks +6 lines, -8 lines 0 comments Download
A + webrtc/modules/congestion_controller/congestion_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
A + webrtc/modules/congestion_controller/congestion_controller.gypi View 1 2 chunks +7 lines, -8 lines 0 comments Download
A + webrtc/modules/congestion_controller/include/congestion_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + webrtc/modules/congestion_controller/include/mock/mock_congestion_controller.h View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/modules.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
stefan-webrtc
Add gypi and gn files.
4 years, 10 months ago (2016-02-19 10:13:56 UTC) #1
stefan-webrtc
Fix gn
4 years, 10 months ago (2016-02-19 10:22:39 UTC) #2
stefan-webrtc
4 years, 10 months ago (2016-02-19 10:24:31 UTC) #4
pbos-webrtc
lgtm, I'd prefer mock/ over include/mock/ we can still make mock/ part of the presubmit ...
4 years, 10 months ago (2016-02-19 13:39:04 UTC) #7
mflodman
LGTM For the record: This breaks the assumption on modules not depending on each other, ...
4 years, 10 months ago (2016-02-23 10:34:40 UTC) #8
stefan-webrtc
On 2016/02/23 10:34:40, mflodman wrote: > LGTM > > For the record: > This breaks ...
4 years, 10 months ago (2016-02-23 10:36:01 UTC) #9
stefan-webrtc
Add presubmit
4 years, 10 months ago (2016-02-23 10:52:30 UTC) #10
stefan-webrtc
Added presubmits. Won't move the mock since it's in line with where most of the ...
4 years, 10 months ago (2016-02-23 10:53:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1718473002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1718473002/60001
4 years, 10 months ago (2016-02-23 10:54:18 UTC) #14
stefan-webrtc
Committed patchset #4 (id:60001) manually as 80e12072cf9667ca25d9edf3b9e8d926dbe2f50c (presubmit successful).
4 years, 10 months ago (2016-02-23 12:30:57 UTC) #17
commit-bot: I haz the power
4 years, 10 months ago (2016-02-23 12:30:57 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/80e12072cf9667ca25d9edf3b9e8d926dbe2f50c
Cr-Commit-Position: refs/heads/master@{#11718}

Powered by Google App Engine
This is Rietveld 408576698