Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1717763003:
Tune QP thresholds for HW H.264 encoder. (Closed)
DescriptionTune QP thresholds for HW H.264 encoder.
Boost low QP threashold to 21, otherwise VGA encoding never
scales up even at 2.5 Mbps.
Also reduce high QP threshold to scale down faster.
BUG=b/26504665
R=jackychen@google.com
Committed: https://crrev.com/67b81f92f4bd16b1d640553339b729cb17b3827e
Cr-Commit-Position: refs/heads/master@{#11712}
Patch Set 1 #
Messages
Total messages: 17 (10 generated)
Description was changed from ========== Tune QP thresholds for HW h.264 encoder. Boost low QP threashold to 21, otherwise VGA encoding never scales up eventat 2.5 Mbps. Also reduce high QP threshold to scale down faster. BUG=b/26504665 ========== to ========== Tune QP thresholds for HW h.264 encoder. Boost low QP threashold to 21, otherwise VGA encoding never scales up eventat 2.5 Mbps. Also reduce high QP threshold to scale down faster. BUG=b/26504665 ==========
Description was changed from ========== Tune QP thresholds for HW h.264 encoder. Boost low QP threashold to 21, otherwise VGA encoding never scales up eventat 2.5 Mbps. Also reduce high QP threshold to scale down faster. BUG=b/26504665 ========== to ========== Tune QP thresholds for HW H.264 encoder. Boost low QP threashold to 21, otherwise VGA encoding never scales up eventat 2.5 Mbps. Also reduce high QP threshold to scale down faster. BUG=b/26504665 ==========
Description was changed from ========== Tune QP thresholds for HW H.264 encoder. Boost low QP threashold to 21, otherwise VGA encoding never scales up eventat 2.5 Mbps. Also reduce high QP threshold to scale down faster. BUG=b/26504665 ========== to ========== Tune QP thresholds for HW H.264 encoder. Boost low QP threashold to 21, otherwise VGA encoding never scales up even at 2.5 Mbps. Also reduce high QP threshold to scale down faster. BUG=b/26504665 ==========
glaznev@webrtc.org changed reviewers: + pbos@webrtc.org
PTAL
pbos@webrtc.org changed reviewers: + jackychen@webrtc.org, mflodman@webrtc.org
+R jackychen/mflodman@
jackychen@google.com changed reviewers: + jackychen@google.com
lgtm.
The CQ bit was checked by glaznev@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1717763003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1717763003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios_arm64_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/7569)
Description was changed from ========== Tune QP thresholds for HW H.264 encoder. Boost low QP threashold to 21, otherwise VGA encoding never scales up even at 2.5 Mbps. Also reduce high QP threshold to scale down faster. BUG=b/26504665 ========== to ========== Tune QP thresholds for HW H.264 encoder. Boost low QP threashold to 21, otherwise VGA encoding never scales up even at 2.5 Mbps. Also reduce high QP threshold to scale down faster. BUG=b/26504665 R=jackychen@google.com Committed: https://chromium.googlesource.com/external/webrtc/+/67b81f92f4bd16b1d64055333... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 67b81f92f4bd16b1d640553339b729cb17b3827e (presubmit successful).
Message was sent while issue was closed.
Description was changed from ========== Tune QP thresholds for HW H.264 encoder. Boost low QP threashold to 21, otherwise VGA encoding never scales up even at 2.5 Mbps. Also reduce high QP threshold to scale down faster. BUG=b/26504665 R=jackychen@google.com Committed: https://chromium.googlesource.com/external/webrtc/+/67b81f92f4bd16b1d64055333... ========== to ========== Tune QP thresholds for HW H.264 encoder. Boost low QP threashold to 21, otherwise VGA encoding never scales up even at 2.5 Mbps. Also reduce high QP threshold to scale down faster. BUG=b/26504665 R=jackychen@google.com Committed: https://crrev.com/67b81f92f4bd16b1d640553339b729cb17b3827e Cr-Commit-Position: refs/heads/master@{#11712} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/67b81f92f4bd16b1d640553339b729cb17b3827e Cr-Commit-Position: refs/heads/master@{#11712} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
