webrtc/api/webrtcsession.h - Issue 1717583002: Non-constraint interfaces for all constrainable interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/api/webrtcsession.h

Issue 1717583002: Non-constraint interfaces for all constrainable interfaces (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Review comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/api/webrtcsession.h

diff --git a/webrtc/api/webrtcsession.h b/webrtc/api/webrtcsession.h

index 70265d30434e012369a508bf0e847553bb17dd07..87379abd8dfc3f7b03dee9edd62275b52875e3d7 100644

--- a/webrtc/api/webrtcsession.h

+++ b/webrtc/api/webrtcsession.h

@@ -147,7 +147,6 @@ class WebRtcSession : public AudioProviderInterface,

bool Initialize(

const PeerConnectionFactoryInterface::Options& options,

- const MediaConstraintsInterface* constraints,

rtc::scoped_ptr<DtlsIdentityStoreInterface> dtls_identity_store,

const PeerConnectionInterface::RTCConfiguration& rtc_configuration);

// Deletes the voice, video and data channel and changes the session state

@@ -197,7 +196,6 @@ class WebRtcSession : public AudioProviderInterface,

const PeerConnectionInterface::RTCOfferAnswerOptions& options,

const cricket::MediaSessionOptions& session_options);

void CreateAnswer(CreateSessionDescriptionObserver* observer,

- const MediaConstraintsInterface* constraints,

const cricket::MediaSessionOptions& session_options);

// The ownership of |desc| will be transferred after this call.

bool SetLocalDescription(SessionDescriptionInterface* desc,

« no previous file with comments | « webrtc/api/videosource.cc ('k') | webrtc/api/webrtcsession.cc » ('j') | no next file with comments »