Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: webrtc/api/videosource.h

Issue 1717583002: Non-constraint interfaces for all constrainable interfaces (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/peerconnectionproxy.h ('k') | webrtc/api/videosource.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/videosource.h
diff --git a/webrtc/api/videosource.h b/webrtc/api/videosource.h
index 634c47ae371268e3ccf04dea21c2ccb0b2d4145c..eb4646336db4c8fa94e8cb2a9e3c0c2f0398d196 100644
--- a/webrtc/api/videosource.h
+++ b/webrtc/api/videosource.h
@@ -47,6 +47,13 @@ class VideoSource : public Notifier<VideoSourceInterface>,
const webrtc::MediaConstraintsInterface* constraints,
bool remote);
+ // Note that the non-constraints version does not have the ability to
+ // select configuration based on width, height, aspect ratio or frame rate.
+ static rtc::scoped_refptr<VideoSource> Create(
+ rtc::Thread* worker_thread,
+ cricket::VideoCapturer* capturer,
+ bool remote);
+
SourceState state() const override { return state_; }
bool remote() const override { return remote_; }
« no previous file with comments | « webrtc/api/peerconnectionproxy.h ('k') | webrtc/api/videosource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698