Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: webrtc/api/localaudiosource.h

Issue 1717583002: Non-constraint interfaces for all constrainable interfaces (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Review comments Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/api/api_tests.gyp ('k') | webrtc/api/localaudiosource.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/api/localaudiosource.h
diff --git a/webrtc/api/localaudiosource.h b/webrtc/api/localaudiosource.h
index d463d1ccd837113e2fc90c7203c8148e7b9e5054..e4de650537fca67ba53bd3105e261b1cf6034956 100644
--- a/webrtc/api/localaudiosource.h
+++ b/webrtc/api/localaudiosource.h
@@ -31,7 +31,11 @@ class LocalAudioSource : public Notifier<AudioSourceInterface> {
const PeerConnectionFactoryInterface::Options& options,
const MediaConstraintsInterface* constraints);
- SourceState state() const override { return source_state_; }
+ static rtc::scoped_refptr<LocalAudioSource> Create(
+ const PeerConnectionFactoryInterface::Options& options,
+ const cricket::AudioOptions* audio_options);
+
+ SourceState state() const override { return kLive; }
bool remote() const override { return false; }
virtual const cricket::AudioOptions& options() const { return options_; }
@@ -40,15 +44,16 @@ class LocalAudioSource : public Notifier<AudioSourceInterface> {
void RemoveSink(AudioTrackSinkInterface* sink) override {}
protected:
- LocalAudioSource() : source_state_(kInitializing) {}
+ LocalAudioSource() {}
~LocalAudioSource() override {}
private:
void Initialize(const PeerConnectionFactoryInterface::Options& options,
const MediaConstraintsInterface* constraints);
+ void Initialize(const PeerConnectionFactoryInterface::Options& options,
+ const cricket::AudioOptions* audio_options);
cricket::AudioOptions options_;
- SourceState source_state_;
};
} // namespace webrtc
« no previous file with comments | « webrtc/api/api_tests.gyp ('k') | webrtc/api/localaudiosource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698