Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: webrtc/api/videosource.h

Issue 1717583002: Non-constraint interfaces for all constrainable interfaces (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Review comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/peerconnectionproxy.h ('k') | webrtc/api/videosource.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 29 matching lines...) Expand all
40 // Creates an instance of VideoSource. 40 // Creates an instance of VideoSource.
41 // VideoSource take ownership of |capturer|. 41 // VideoSource take ownership of |capturer|.
42 // |constraints| can be NULL and in that case the camera is opened using a 42 // |constraints| can be NULL and in that case the camera is opened using a
43 // default resolution. 43 // default resolution.
44 static rtc::scoped_refptr<VideoSource> Create( 44 static rtc::scoped_refptr<VideoSource> Create(
45 rtc::Thread* worker_thread, 45 rtc::Thread* worker_thread,
46 cricket::VideoCapturer* capturer, 46 cricket::VideoCapturer* capturer,
47 const webrtc::MediaConstraintsInterface* constraints, 47 const webrtc::MediaConstraintsInterface* constraints,
48 bool remote); 48 bool remote);
49 49
50 // Note that the non-constraints version does not have the ability to
51 // select configuration based on width, height, aspect ratio or frame rate.
52 static rtc::scoped_refptr<VideoSource> Create(
53 rtc::Thread* worker_thread,
54 cricket::VideoCapturer* capturer,
55 bool remote);
56
50 SourceState state() const override { return state_; } 57 SourceState state() const override { return state_; }
51 bool remote() const override { return remote_; } 58 bool remote() const override { return remote_; }
52 59
53 virtual const cricket::VideoOptions* options() const { return &options_; } 60 virtual const cricket::VideoOptions* options() const { return &options_; }
54 61
55 virtual cricket::VideoCapturer* GetVideoCapturer() { 62 virtual cricket::VideoCapturer* GetVideoCapturer() {
56 return video_capturer_.get(); 63 return video_capturer_.get();
57 } 64 }
58 65
59 void Stop() override; 66 void Stop() override;
(...skipping 24 matching lines...) Expand all
84 91
85 cricket::VideoFormat format_; 92 cricket::VideoFormat format_;
86 cricket::VideoOptions options_; 93 cricket::VideoOptions options_;
87 SourceState state_; 94 SourceState state_;
88 const bool remote_; 95 const bool remote_;
89 }; 96 };
90 97
91 } // namespace webrtc 98 } // namespace webrtc
92 99
93 #endif // WEBRTC_API_VIDEOSOURCE_H_ 100 #endif // WEBRTC_API_VIDEOSOURCE_H_
OLDNEW
« no previous file with comments | « webrtc/api/peerconnectionproxy.h ('k') | webrtc/api/videosource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698