Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: webrtc/api/peerconnectionfactoryproxy.h

Issue 1717583002: Non-constraint interfaces for all constrainable interfaces (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Review comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/peerconnectionfactory.cc ('k') | webrtc/api/peerconnectioninterface.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2014 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2014 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 16 matching lines...) Expand all
27 rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnection( 27 rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnection(
28 const PeerConnectionInterface::RTCConfiguration& a1, 28 const PeerConnectionInterface::RTCConfiguration& a1,
29 const MediaConstraintsInterface* a2, 29 const MediaConstraintsInterface* a2,
30 rtc::scoped_ptr<cricket::PortAllocator> a3, 30 rtc::scoped_ptr<cricket::PortAllocator> a3,
31 rtc::scoped_ptr<DtlsIdentityStoreInterface> a4, 31 rtc::scoped_ptr<DtlsIdentityStoreInterface> a4,
32 PeerConnectionObserver* a5) override { 32 PeerConnectionObserver* a5) override {
33 return owner_thread_->Invoke<rtc::scoped_refptr<PeerConnectionInterface>>( 33 return owner_thread_->Invoke<rtc::scoped_refptr<PeerConnectionInterface>>(
34 rtc::Bind(&PeerConnectionFactoryProxy::CreatePeerConnection_ot, this, 34 rtc::Bind(&PeerConnectionFactoryProxy::CreatePeerConnection_ot, this,
35 a1, a2, a3.release(), a4.release(), a5)); 35 a1, a2, a3.release(), a4.release(), a5));
36 } 36 }
37 rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnection(
38 const PeerConnectionInterface::RTCConfiguration& a1,
39 rtc::scoped_ptr<cricket::PortAllocator> a3,
40 rtc::scoped_ptr<DtlsIdentityStoreInterface> a4,
41 PeerConnectionObserver* a5) override {
42 return owner_thread_->Invoke<rtc::scoped_refptr<PeerConnectionInterface>>(
43 rtc::Bind(&PeerConnectionFactoryProxy::CreatePeerConnection_ot, this,
44 a1, a3.release(), a4.release(), a5));
45 }
37 PROXY_METHOD1(rtc::scoped_refptr<MediaStreamInterface>, 46 PROXY_METHOD1(rtc::scoped_refptr<MediaStreamInterface>,
38 CreateLocalMediaStream, const std::string&) 47 CreateLocalMediaStream, const std::string&)
39 PROXY_METHOD1(rtc::scoped_refptr<AudioSourceInterface>, 48 PROXY_METHOD1(rtc::scoped_refptr<AudioSourceInterface>,
40 CreateAudioSource, const MediaConstraintsInterface*) 49 CreateAudioSource, const MediaConstraintsInterface*)
50 PROXY_METHOD1(rtc::scoped_refptr<AudioSourceInterface>,
51 CreateAudioSource,
52 const cricket::AudioOptions&)
41 PROXY_METHOD2(rtc::scoped_refptr<VideoSourceInterface>, 53 PROXY_METHOD2(rtc::scoped_refptr<VideoSourceInterface>,
42 CreateVideoSource, cricket::VideoCapturer*, 54 CreateVideoSource, cricket::VideoCapturer*,
43 const MediaConstraintsInterface*) 55 const MediaConstraintsInterface*)
56 PROXY_METHOD1(rtc::scoped_refptr<VideoSourceInterface>,
57 CreateVideoSource,
58 cricket::VideoCapturer*)
44 PROXY_METHOD2(rtc::scoped_refptr<VideoTrackInterface>, 59 PROXY_METHOD2(rtc::scoped_refptr<VideoTrackInterface>,
45 CreateVideoTrack, const std::string&, VideoSourceInterface*) 60 CreateVideoTrack, const std::string&, VideoSourceInterface*)
46 PROXY_METHOD2(rtc::scoped_refptr<AudioTrackInterface>, 61 PROXY_METHOD2(rtc::scoped_refptr<AudioTrackInterface>,
47 CreateAudioTrack, const std::string&, AudioSourceInterface*) 62 CreateAudioTrack, const std::string&, AudioSourceInterface*)
48 PROXY_METHOD2(bool, StartAecDump, rtc::PlatformFile, int64_t) 63 PROXY_METHOD2(bool, StartAecDump, rtc::PlatformFile, int64_t)
49 PROXY_METHOD0(void, StopAecDump) 64 PROXY_METHOD0(void, StopAecDump)
50 PROXY_METHOD1(bool, StartRtcEventLog, rtc::PlatformFile) 65 PROXY_METHOD1(bool, StartRtcEventLog, rtc::PlatformFile)
51 PROXY_METHOD0(void, StopRtcEventLog) 66 PROXY_METHOD0(void, StopRtcEventLog)
52 67
53 private: 68 private:
54 rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnection_ot( 69 rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnection_ot(
55 const PeerConnectionInterface::RTCConfiguration& a1, 70 const PeerConnectionInterface::RTCConfiguration& a1,
56 const MediaConstraintsInterface* a2, 71 const MediaConstraintsInterface* a2,
57 cricket::PortAllocator* a3, 72 cricket::PortAllocator* a3,
58 DtlsIdentityStoreInterface* a4, 73 DtlsIdentityStoreInterface* a4,
59 PeerConnectionObserver* a5) { 74 PeerConnectionObserver* a5) {
60 rtc::scoped_ptr<cricket::PortAllocator> ptr_a3(a3); 75 rtc::scoped_ptr<cricket::PortAllocator> ptr_a3(a3);
61 rtc::scoped_ptr<DtlsIdentityStoreInterface> ptr_a4(a4); 76 rtc::scoped_ptr<DtlsIdentityStoreInterface> ptr_a4(a4);
62 return c_->CreatePeerConnection(a1, a2, std::move(ptr_a3), 77 return c_->CreatePeerConnection(a1, a2, std::move(ptr_a3),
63 std::move(ptr_a4), a5); 78 std::move(ptr_a4), a5);
64 } 79 }
65 END_PROXY() 80
81 rtc::scoped_refptr<PeerConnectionInterface> CreatePeerConnection_ot(
82 const PeerConnectionInterface::RTCConfiguration& a1,
83 cricket::PortAllocator* a3,
84 DtlsIdentityStoreInterface* a4,
85 PeerConnectionObserver* a5) {
86 rtc::scoped_ptr<cricket::PortAllocator> ptr_a3(a3);
87 rtc::scoped_ptr<DtlsIdentityStoreInterface> ptr_a4(a4);
88 return c_->CreatePeerConnection(a1, std::move(ptr_a3), std::move(ptr_a4),
89 a5);
90 }
91 END_PROXY()
66 92
67 } // namespace webrtc 93 } // namespace webrtc
68 94
69 #endif // WEBRTC_API_PEERCONNECTIONFACTORYPROXY_H_ 95 #endif // WEBRTC_API_PEERCONNECTIONFACTORYPROXY_H_
OLDNEW
« no previous file with comments | « webrtc/api/peerconnectionfactory.cc ('k') | webrtc/api/peerconnectioninterface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698