Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: webrtc/api/localaudiosource_unittest.cc

Issue 1717583002: Non-constraint interfaces for all constrainable interfaces (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Review comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/localaudiosource.cc ('k') | webrtc/api/mediaconstraintsinterface.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 constraints.AddMandatory(MediaConstraintsInterface::kHighpassFilter, false); 89 constraints.AddMandatory(MediaConstraintsInterface::kHighpassFilter, false);
90 constraints.AddMandatory("invalidKey", false); 90 constraints.AddMandatory("invalidKey", false);
91 91
92 rtc::scoped_refptr<LocalAudioSource> source = 92 rtc::scoped_refptr<LocalAudioSource> source =
93 LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(), 93 LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),
94 &constraints); 94 &constraints);
95 95
96 EXPECT_EQ(MediaSourceInterface::kLive, source->state()); 96 EXPECT_EQ(MediaSourceInterface::kLive, source->state());
97 EXPECT_EQ(rtc::Optional<bool>(false), source->options().highpass_filter); 97 EXPECT_EQ(rtc::Optional<bool>(false), source->options().highpass_filter);
98 } 98 }
99
100 TEST(LocalAudioSourceTest, InitWithAudioOptions) {
101 cricket::AudioOptions audio_options;
102 audio_options.highpass_filter = rtc::Optional<bool>(true);
103 rtc::scoped_refptr<LocalAudioSource> source = LocalAudioSource::Create(
104 PeerConnectionFactoryInterface::Options(), &audio_options);
105 EXPECT_EQ(rtc::Optional<bool>(true), source->options().highpass_filter);
106 }
107
108 TEST(LocalAudioSourceTest, InitWithNoOptions) {
109 rtc::scoped_refptr<LocalAudioSource> source =
110 LocalAudioSource::Create(PeerConnectionFactoryInterface::Options(),
111 (cricket::AudioOptions*)nullptr);
112 EXPECT_EQ(rtc::Optional<bool>(), source->options().highpass_filter);
113 }
OLDNEW
« no previous file with comments | « webrtc/api/localaudiosource.cc ('k') | webrtc/api/mediaconstraintsinterface.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698