Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Side by Side Diff: webrtc/api/localaudiosource.h

Issue 1717583002: Non-constraint interfaces for all constrainable interfaces (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Review comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/api/api_tests.gyp ('k') | webrtc/api/localaudiosource.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 13 matching lines...) Expand all
24 24
25 class MediaConstraintsInterface; 25 class MediaConstraintsInterface;
26 26
27 class LocalAudioSource : public Notifier<AudioSourceInterface> { 27 class LocalAudioSource : public Notifier<AudioSourceInterface> {
28 public: 28 public:
29 // Creates an instance of LocalAudioSource. 29 // Creates an instance of LocalAudioSource.
30 static rtc::scoped_refptr<LocalAudioSource> Create( 30 static rtc::scoped_refptr<LocalAudioSource> Create(
31 const PeerConnectionFactoryInterface::Options& options, 31 const PeerConnectionFactoryInterface::Options& options,
32 const MediaConstraintsInterface* constraints); 32 const MediaConstraintsInterface* constraints);
33 33
34 SourceState state() const override { return source_state_; } 34 static rtc::scoped_refptr<LocalAudioSource> Create(
35 const PeerConnectionFactoryInterface::Options& options,
36 const cricket::AudioOptions* audio_options);
37
38 SourceState state() const override { return kLive; }
35 bool remote() const override { return false; } 39 bool remote() const override { return false; }
36 40
37 virtual const cricket::AudioOptions& options() const { return options_; } 41 virtual const cricket::AudioOptions& options() const { return options_; }
38 42
39 void AddSink(AudioTrackSinkInterface* sink) override {} 43 void AddSink(AudioTrackSinkInterface* sink) override {}
40 void RemoveSink(AudioTrackSinkInterface* sink) override {} 44 void RemoveSink(AudioTrackSinkInterface* sink) override {}
41 45
42 protected: 46 protected:
43 LocalAudioSource() : source_state_(kInitializing) {} 47 LocalAudioSource() {}
44 ~LocalAudioSource() override {} 48 ~LocalAudioSource() override {}
45 49
46 private: 50 private:
47 void Initialize(const PeerConnectionFactoryInterface::Options& options, 51 void Initialize(const PeerConnectionFactoryInterface::Options& options,
48 const MediaConstraintsInterface* constraints); 52 const MediaConstraintsInterface* constraints);
53 void Initialize(const PeerConnectionFactoryInterface::Options& options,
54 const cricket::AudioOptions* audio_options);
49 55
50 cricket::AudioOptions options_; 56 cricket::AudioOptions options_;
51 SourceState source_state_;
52 }; 57 };
53 58
54 } // namespace webrtc 59 } // namespace webrtc
55 60
56 #endif // WEBRTC_API_LOCALAUDIOSOURCE_H_ 61 #endif // WEBRTC_API_LOCALAUDIOSOURCE_H_
OLDNEW
« no previous file with comments | « webrtc/api/api_tests.gyp ('k') | webrtc/api/localaudiosource.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698