Non-constraint interfaces for all constrainable interfaces

webrtc/api/localaudiosource.h

 /*
  *  Copyright 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 13 matching lines @@
 
 class MediaConstraintsInterface;
 
 class LocalAudioSource : public Notifier<AudioSourceInterface> {
  public:
   // Creates an instance of LocalAudioSource.
   static rtc::scoped_refptr<LocalAudioSource> Create(
       const PeerConnectionFactoryInterface::Options& options,
       const MediaConstraintsInterface* constraints);
 
+  static rtc::scoped_refptr<LocalAudioSource> Create(
+      const PeerConnectionFactoryInterface::Options& options,
+      const cricket::AudioOptions* audio_options);
+
   SourceState state() const override { return source_state_; }
   bool remote() const override { return false; }
 
   virtual const cricket::AudioOptions& options() const { return options_; }
 
   void AddSink(AudioTrackSinkInterface* sink) override {}
   void RemoveSink(AudioTrackSinkInterface* sink) override {}
 
  protected:
   LocalAudioSource() : source_state_(kInitializing) {}

[nisse-webrtc, 2016/02/26 08:53:45]

I guess that's also for a separate refactoring cl, but I'd really like to kill
all "kInitializing" states. When creating an object, just make sure that it is
valid and fully initialized before taking it into use.

[hta-webrtc, 2016/02/29 11:09:48]

Yes, I think it is separate. Filing a bug would be appropriate (so that we do
not forget). Bug webrtc:5604 filed.

   ~LocalAudioSource() override {}
 
  private:
   void Initialize(const PeerConnectionFactoryInterface::Options& options,
                   const MediaConstraintsInterface* constraints);
+  void Initialize(const PeerConnectionFactoryInterface::Options& options,
+                  const cricket::AudioOptions* audio_options);
 
   cricket::AudioOptions options_;
   SourceState source_state_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_API_LOCALAUDIOSOURCE_H_