Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1716203002:
Fixed Aec handle index in EchoCancellationImpl that was not updated as it should. (Closed)
|
Created:
4 years, 10 months ago by peah-webrtc Modified:
4 years, 9 months ago Reviewers:
hlundin-webrtc CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionFixed Aec handle index in EchoCancellationImpl
that was not updated as it should.
The bug caused no negative impact at all apart
from a missed check that the Aec handles above
index 0 were not null. That check is, however,
done elsewhere so there was no negative impact
of this bug.
BUG=
Committed: https://crrev.com/fc4ff2d92c56a3b973f69bef2c712ec02ea2d599
Cr-Commit-Position: refs/heads/master@{#11863}
Patch Set 1 #Patch Set 2 : Merge from master #Messages
Total messages: 23 (12 generated)
Description was changed from ========== Fixed handle index that was not updated. BUG= ========== to ========== Fixed Aec handle index in EchoCancellationImpl that was not updated as it should. The bug caused no negative impact at all apart from a missed check that the Aec handles above index 0 were not null. That check is, however, done elsewhere so there was no negative impact of this bug. BUG= ==========
peah@webrtc.org changed reviewers: + henrik.lundin@webrtc.org
lgtm
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716203002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716203002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by peah@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from henrik.lundin@webrtc.org Link to the patchset: https://codereview.webrtc.org/1716203002/#ps20001 (title: "Merge from master")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716203002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL) linux_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL) win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1716203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1716203002/20001
Message was sent while issue was closed.
Description was changed from ========== Fixed Aec handle index in EchoCancellationImpl that was not updated as it should. The bug caused no negative impact at all apart from a missed check that the Aec handles above index 0 were not null. That check is, however, done elsewhere so there was no negative impact of this bug. BUG= ========== to ========== Fixed Aec handle index in EchoCancellationImpl that was not updated as it should. The bug caused no negative impact at all apart from a missed check that the Aec handles above index 0 were not null. That check is, however, done elsewhere so there was no negative impact of this bug. BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fixed Aec handle index in EchoCancellationImpl that was not updated as it should. The bug caused no negative impact at all apart from a missed check that the Aec handles above index 0 were not null. That check is, however, done elsewhere so there was no negative impact of this bug. BUG= ========== to ========== Fixed Aec handle index in EchoCancellationImpl that was not updated as it should. The bug caused no negative impact at all apart from a missed check that the Aec handles above index 0 were not null. That check is, however, done elsewhere so there was no negative impact of this bug. BUG= Committed: https://crrev.com/fc4ff2d92c56a3b973f69bef2c712ec02ea2d599 Cr-Commit-Position: refs/heads/master@{#11863} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/fc4ff2d92c56a3b973f69bef2c712ec02ea2d599 Cr-Commit-Position: refs/heads/master@{#11863} |
