Simple RTCP receiver fuzzer.

Simple RTCP receiver fuzzer.

Doesn't utilize the clock or any callbacks out of the receiver but
should still be useful to test input packet parsing.

BUG=webrtc:4771
R=danilchap@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/ba3e25e50296518cccca4732b769e698dfc03365

[pbos-webrtc, 2016-02-22 10:13:03]

PTAL

[danilchap, 2016-02-22 12:22:55]

https://codereview.webrtc.org/1716143002/diff/1/webrtc/test/fuzzers/rtcp_rece...
File webrtc/test/fuzzers/rtcp_receiver_fuzzer.cc (right):

https://codereview.webrtc.org/1716143002/diff/1/webrtc/test/fuzzers/rtcp_rece...
webrtc/test/fuzzers/rtcp_receiver_fuzzer.cc:20: nullptr);
May be you want to use input (data,size) parameters instead of ignoring them.
RTCPReceiver doesn't have single input right now.
One way to call parser is to create RtpRtcp module. It has proper
IncomingRtcpPacket(const uint8_t*, size_t).
Another way - copy it's implementation except for callbacks.
Third way: help land CL https://codereview.webrtc.org/1527003002/ where
IncompingRtcpPacket pushed from RtpRtcp to RtcpReceiver.

[pbos-webrtc, 2016-02-22 12:31:45]

use implementation

[pbos-webrtc, 2016-02-22 12:31:50]

https://codereview.webrtc.org/1716143002/diff/1/webrtc/test/fuzzers/rtcp_rece...
File webrtc/test/fuzzers/rtcp_receiver_fuzzer.cc (right):

https://codereview.webrtc.org/1716143002/diff/1/webrtc/test/fuzzers/rtcp_rece...
webrtc/test/fuzzers/rtcp_receiver_fuzzer.cc:20: nullptr);
On 2016/02/22 12:22:55, danilchap wrote:
> May be you want to use input (data,size) parameters instead of ignoring them.
> RTCPReceiver doesn't have single input right now.
> One way to call parser is to create RtpRtcp module. It has proper
> IncomingRtcpPacket(const uint8_t*, size_t).
> Another way - copy it's implementation except for callbacks.
> Third way: help land CL https://codereview.webrtc.org/1527003002/ where
> IncompingRtcpPacket pushed from RtpRtcp to RtcpReceiver.

Wow, good call. I really missed that I was not even using data,size. PTAL

[danilchap, 2016-02-22 12:48:51]

https://codereview.webrtc.org/1716143002/diff/20001/webrtc/test/fuzzers/rtcp_...
File webrtc/test/fuzzers/rtcp_receiver_fuzzer.cc (right):

https://codereview.webrtc.org/1716143002/diff/20001/webrtc/test/fuzzers/rtcp_...
webrtc/test/fuzzers/rtcp_receiver_fuzzer.cc:24: nullptr);
Last parameter can't be null: Should point to RtpRtcp module.

It is currently used both for parsing and for callbacks.
Either use a mock object, or wait CL https://codereview.webrtc.org/1491843004/
where, as side effect, I remove calling RtpRtcp module during parse step.

[pbos-webrtc, 2016-02-22 12:49:52]

On 2016/02/22 12:48:51, danilchap wrote:
>
https://codereview.webrtc.org/1716143002/diff/20001/webrtc/test/fuzzers/rtcp_...
> File webrtc/test/fuzzers/rtcp_receiver_fuzzer.cc (right):
> 
>
https://codereview.webrtc.org/1716143002/diff/20001/webrtc/test/fuzzers/rtcp_...
> webrtc/test/fuzzers/rtcp_receiver_fuzzer.cc:24: nullptr);
> Last parameter can't be null: Should point to RtpRtcp module.
> 
> It is currently used both for parsing and for callbacks.
> Either use a mock object, or wait CL https://codereview.webrtc.org/1491843004/
> where, as side effect, I remove calling RtpRtcp module during parse step.

I'll do the latter then, please ping when you think it's ready to be picked up
again. :)

[danilchap, 2016-02-22 18:44:21]

On 2016/02/22 12:49:52, pbos-webrtc wrote:
> On 2016/02/22 12:48:51, danilchap wrote:
> >
>
https://codereview.webrtc.org/1716143002/diff/20001/webrtc/test/fuzzers/rtcp_...
> > File webrtc/test/fuzzers/rtcp_receiver_fuzzer.cc (right):
> > 
> >
>
https://codereview.webrtc.org/1716143002/diff/20001/webrtc/test/fuzzers/rtcp_...
> > webrtc/test/fuzzers/rtcp_receiver_fuzzer.cc:24: nullptr);
> > Last parameter can't be null: Should point to RtpRtcp module.
> > 
> > It is currently used both for parsing and for callbacks.
> > Either use a mock object, or wait CL
https://codereview.webrtc.org/1491843004/
> > where, as side effect, I remove calling RtpRtcp module during parse step.
> 
> I'll do the latter then, please ping when you think it's ready to be picked up
> again. :)

should be ready.
lgtm

[commit-bot: I haz the power, 2016-02-23 10:35:47]

Description was changed from

==========
Simple RTCP receiver fuzzer.

Doesn't utilize the clock or any callbacks out of the receiver but
should still be useful to test input packet parsing.

BUG=webrtc:4771
R=danilchap@webrtc.org
==========

to

==========
Simple RTCP receiver fuzzer.

Doesn't utilize the clock or any callbacks out of the receiver but
should still be useful to test input packet parsing.

BUG=webrtc:4771
R=danilchap@webrtc.org

Committed: https://crrev.com/ba3e25e50296518cccca4732b769e698dfc03365
Cr-Commit-Position: refs/heads/master@{#11717}
==========

[commit-bot: I haz the power, 2016-02-23 10:35:48]

Patchset 2 (id:??) landed as
https://crrev.com/ba3e25e50296518cccca4732b769e698dfc03365
Cr-Commit-Position: refs/heads/master@{#11717}

[pbos-webrtc, 2016-02-23 10:35:50]

Description was changed from

==========
Simple RTCP receiver fuzzer.

Doesn't utilize the clock or any callbacks out of the receiver but
should still be useful to test input packet parsing.

BUG=webrtc:4771
R=danilchap@webrtc.org

Committed: https://crrev.com/ba3e25e50296518cccca4732b769e698dfc03365
Cr-Commit-Position: refs/heads/master@{#11717}
==========

to

==========
Simple RTCP receiver fuzzer.

Doesn't utilize the clock or any callbacks out of the receiver but
should still be useful to test input packet parsing.

BUG=webrtc:4771
R=danilchap@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/ba3e25e50296518cccca4732b...
==========

[pbos-webrtc, 2016-02-23 10:35:51]

Committed patchset #2 (id:20001) manually as
ba3e25e50296518cccca4732b769e698dfc03365 (presubmit successful).