Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(830)

Unified Diff: webrtc/api/api.gyp

Issue 1715883002: Remove DeviceManager and DeviceInfo. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/api/api.gyp
diff --git a/webrtc/api/api.gyp b/webrtc/api/api.gyp
index 4fe8ce845884faf8014450b9431e77a9ef45b03b..c653e889df3f3e2f5278a2825a68533ca7a92bf2 100644
--- a/webrtc/api/api.gyp
+++ b/webrtc/api/api.gyp
@@ -337,6 +337,17 @@
'-Wno-maybe-uninitialized', # Only exists for GCC.
],
}],
+ # TODO(solenberg): Doesn't work adding the flag to 'rtc_api_objc'. Why?
tkchin_webrtc 2016/03/02 21:13:37 try sticking it in an all_dependent_settings block
the sun 2016/03/03 20:00:14 I didn't realize there were two targets with very
+ # See https://bugs.chromium.org/p/webrtc/issues/detail?id=5620
+ ['OS=="mac"', {
+ 'link_settings': {
+ 'xcode_settings': {
+ 'OTHER_LDFLAGS': [
+ '-framework OpenGL',
+ ],
+ },
+ },
+ }],
['OS=="win"', {
# Disable warning for signed/unsigned mismatch.
'msvs_settings': {

Powered by Google App Engine
This is Rietveld 408576698