Fix sequence-number replay race for padding.

Fix sequence-number replay race for padding.

Prevents allocating sequence numbers for packets that go out on the
network even though sending media is disabled.

This race caused a replay of sequence numbers when GetRtpState() on a
stopped stream would not return the last sequence number sent, since the
pacer thread could request and send padding on a later sequence number
before the modules are disconnected from the pacer.

BUG=webrtc:5543
R=stefan@webrtc.org
TEST=Repeating EndToEndTest.RestartingSendStreamPreservesRtpState 1000 times under TSan.

Committed: https://crrev.com/fc968a283c91cd4395b0ee8f232d29d566cc1316
Cr-Commit-Position: refs/heads/master@{#11685}

[pbos-webrtc, 2016-02-19 15:11:30]

PTAL

https://codereview.webrtc.org/1715703002/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/rtp_sender.cc (left):

https://codereview.webrtc.org/1715703002/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/rtp_sender.cc:1014: {
This check is now done in TrySendRedundantPayloads as well as SendPadData, so no
need to acquire the lock once more, and we have to check inside both those
functions as well.

[stefan-webrtc, 2016-02-19 15:12:55]

lgtm

[pbos-webrtc, 2016-02-19 15:14:49]

Description was changed from

==========
Fix sequence-number replay race for padding.

Prevents allocating sequence numbers for packets that go out on the
network even though sending media is disabled.

This race caused a replay of sequence numbers when GetRtpState() on a
stopped stream would not return the last sequence number sent, since the
pacer thread could request and send padding on a later sequence number
before the modules are disconnected from the pacer.

BUG=webrtc:5543
R=stefan@webrtc.org
TEST=Repeating EndToEndTest.RestartingSendStreamPreservesRtpState 1000 times
under TSan.
==========

to

==========
Fix sequence-number replay race for padding.

Prevents allocating sequence numbers for packets that go out on the
network even though sending media is disabled.

This race caused a replay of sequence numbers when GetRtpState() on a
stopped stream would not return the last sequence number sent, since the
pacer thread could request and send padding on a later sequence number
before the modules are disconnected from the pacer.

BUG=webrtc:5543
R=stefan@webrtc.org
TEST=Repeating EndToEndTest.RestartingSendStreamPreservesRtpState 1000 times
under TSan.

Committed:
https://chromium.googlesource.com/external/webrtc/+/fc968a283c91cd4395b0ee8f2...
==========

[pbos-webrtc, 2016-02-19 15:14:51]

Committed patchset #1 (id:1) manually as
fc968a283c91cd4395b0ee8f232d29d566cc1316 (presubmit successful).

[commit-bot: I haz the power, 2016-02-19 15:14:52]

Description was changed from

==========
Fix sequence-number replay race for padding.

Prevents allocating sequence numbers for packets that go out on the
network even though sending media is disabled.

This race caused a replay of sequence numbers when GetRtpState() on a
stopped stream would not return the last sequence number sent, since the
pacer thread could request and send padding on a later sequence number
before the modules are disconnected from the pacer.

BUG=webrtc:5543
R=stefan@webrtc.org
TEST=Repeating EndToEndTest.RestartingSendStreamPreservesRtpState 1000 times
under TSan.

Committed:
https://chromium.googlesource.com/external/webrtc/+/fc968a283c91cd4395b0ee8f2...
==========

to

==========
Fix sequence-number replay race for padding.

Prevents allocating sequence numbers for packets that go out on the
network even though sending media is disabled.

This race caused a replay of sequence numbers when GetRtpState() on a
stopped stream would not return the last sequence number sent, since the
pacer thread could request and send padding on a later sequence number
before the modules are disconnected from the pacer.

BUG=webrtc:5543
R=stefan@webrtc.org
TEST=Repeating EndToEndTest.RestartingSendStreamPreservesRtpState 1000 times
under TSan.

Committed: https://crrev.com/fc968a283c91cd4395b0ee8f232d29d566cc1316
Cr-Commit-Position: refs/heads/master@{#11685}
==========

[commit-bot: I haz the power, 2016-02-19 15:14:53]

Patchset 1 (id:??) landed as
https://crrev.com/fc968a283c91cd4395b0ee8f232d29d566cc1316
Cr-Commit-Position: refs/heads/master@{#11685}