Implement the NackModule as part of the new jitter buffer.

webrtc/base/mod_ops_unittest.cc

Index: webrtc/base/mod_ops_unittest.cc
diff --git a/webrtc/base/mod_ops_unittest.cc b/webrtc/base/mod_ops_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..13e638fb6e87ca62500aca0064bfba0447f62ea6
--- /dev/null
+++ b/webrtc/base/mod_ops_unittest.cc
@@ -0,0 +1,172 @@
+/*
+ *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include "testing/gtest/include/gtest/gtest.h"
+#include "webrtc/base/mod_ops.h"
+
+namespace webrtc {
+class TestModOps : public ::testing::Test {
+ protected:
+  // Can't use std::numeric_limits<unsigned long>::max() since
+  // MSVC doesn't support constexpr.
+  static const unsigned long ulmax = ~0ul;  // NOLINT
+};
+
+TEST_F(TestModOps, Add) {
+  const int D = 100;
+  EXPECT_EQ(1u, Add<D>(0, 1));
+  EXPECT_EQ(0u, Add<D>(0, D));
+  for (int i = 0; i < D; ++i)
+    EXPECT_EQ(0u, Add<D>(i, D - i));
+
+  int t = 37;
+  uint8_t a = t;
+  for (int i = 0; i < 256; ++i) {
+    EXPECT_EQ(a, static_cast<uint8_t>(t));
+    t = Add<256>(t, 1);
+    ++a;
+  }
+}
+
+TEST_F(TestModOps, AddLarge) {
+  // NOLINTNEXTLINE
+  const unsigned long D = ulmax - 10ul;  // NOLINT

[torbjorng (webrtc), 2016/03/04 13:43:29]

Nit: We don't usually put 'ul' suffixes where they are not needed. More examples
below. (But in your EXPECT_* they are sometimes needed to avoid comparisons
between different signedness.)

+  unsigned long l = D - 1ul;             // NOLINT
+  EXPECT_EQ(D - 2ul, Add<D>(l, l));
+  EXPECT_EQ(9ul, Add<D>(l, ulmax));
+  EXPECT_EQ(10ul, Add<D>(0ul, ulmax));
+}
+
+TEST_F(TestModOps, Subtract) {
+  const int D = 100;
+  EXPECT_EQ(99u, Subtract<D>(0, 1));
+  EXPECT_EQ(0u, Subtract<D>(0, D));
+  for (int i = 0; i < D; ++i)
+    EXPECT_EQ(0u, Subtract<D>(i, D + i));
+
+  int t = 37;
+  uint8_t a = t;
+  for (int i = 0; i < 256; ++i) {
+    EXPECT_EQ(a, static_cast<uint8_t>(t));
+    t = Subtract<256>(t, 1);
+    --a;
+  }
+}
+
+TEST_F(TestModOps, SubtractLarge) {
+  // NOLINTNEXTLINE
+  const unsigned long D = ulmax - 10ul;  // NOLINT
+  unsigned long l = D - 1ul;             // NOLINT
+  EXPECT_EQ(0ul, Subtract<D>(l, l));
+  EXPECT_EQ(D - 11ul, Subtract<D>(l, ulmax));
+  EXPECT_EQ(D - 10ul, Subtract<D>(0ul, ulmax));
+}
+
+TEST_F(TestModOps, ForwardDiff) {
+  EXPECT_EQ(0u, ForwardDiff(4711u, 4711u));
+
+  uint8_t x = 0;
+  uint8_t y = 255;
+  for (int i = 0; i < 256; ++i) {
+    EXPECT_EQ(255u, ForwardDiff(x, y));
+    ++x;
+    ++y;
+  }
+
+  int yi = 255;
+  for (int i = 0; i < 256; ++i) {
+    EXPECT_EQ(255u, ForwardDiff<uint8_t>(x, yi));
+    ++x;
+    ++yi;
+  }
+}
+
+TEST_F(TestModOps, ReverseDiff) {
+  EXPECT_EQ(0u, ReverseDiff(4711u, 4711u));
+
+  uint8_t x = 0;
+  uint8_t y = 255;
+  for (int i = 0; i < 256; ++i) {
+    EXPECT_EQ(1u, ReverseDiff(x, y));
+    ++x;
+    ++y;
+  }
+
+  int yi = 255;
+  for (int i = 0; i < 256; ++i) {
+    EXPECT_EQ(1u, ReverseDiff<uint8_t>(x, yi));
+    ++x;
+    ++yi;
+  }
+}
+
+TEST_F(TestModOps, AheadOrAt) {
+  uint8_t x = 0;
+  uint8_t y = 0;
+  EXPECT_TRUE(AheadOrAt(x, y));
+  ++x;
+  EXPECT_TRUE(AheadOrAt(x, y));
+  EXPECT_FALSE(AheadOrAt(y, x));
+  for (int i = 0; i < 256; ++i) {
+    EXPECT_TRUE(AheadOrAt(x, y));
+    ++x;
+    ++y;
+  }
+
+  x = 128;
+  y = 0;
+  EXPECT_TRUE(AheadOrAt(x, y));
+  EXPECT_FALSE(AheadOrAt(y, x));
+
+  x = 129;
+  EXPECT_FALSE(AheadOrAt(x, y));
+  EXPECT_TRUE(AheadOrAt(y, x));
+  EXPECT_TRUE(AheadOrAt<uint16_t>(x, y));
+  EXPECT_FALSE(AheadOrAt<uint16_t>(y, x));
+}
+
+TEST_F(TestModOps, AheadOf) {
+  uint8_t x = 0;
+  uint8_t y = 0;
+  EXPECT_FALSE(AheadOf(x, y));
+  ++x;
+  EXPECT_TRUE(AheadOf(x, y));
+  EXPECT_FALSE(AheadOf(y, x));
+  for (int i = 0; i < 256; ++i) {
+    EXPECT_TRUE(AheadOf(x, y));
+    ++x;
+    ++y;
+  }
+
+  x = 128;
+  y = 0;
+  for (int i = 0; i < 128; ++i) {
+    EXPECT_TRUE(AheadOf(x, y));
+    EXPECT_FALSE(AheadOf(y, x));
+    x++;
+    y++;
+  }
+
+  for (int i = 0; i < 128; ++i) {
+    EXPECT_FALSE(AheadOf(x, y));
+    EXPECT_TRUE(AheadOf(y, x));
+    x++;
+    y++;
+  }
+
+  x = 129;
+  y = 0;
+  EXPECT_FALSE(AheadOf(x, y));
+  EXPECT_TRUE(AheadOf(y, x));
+  EXPECT_TRUE(AheadOf<uint16_t>(x, y));
+  EXPECT_FALSE(AheadOf<uint16_t>(y, x));
+}
+
+}  // namespace webrtc