Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: webrtc/modules/video_coding/include/video_coding_defines.h

Issue 1715673002: Implement the NackModule as part of the new jitter buffer. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Removed commented code. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
153 return -1; 153 return -1;
154 } 154 }
155 155
156 protected: 156 protected:
157 virtual ~VCMFrameTypeCallback() {} 157 virtual ~VCMFrameTypeCallback() {}
158 }; 158 };
159 159
160 // Callback class used for telling the user about which packet sequence numbers 160 // Callback class used for telling the user about which packet sequence numbers
161 // are currently 161 // are currently
162 // missing and need to be resent. 162 // missing and need to be resent.
163 // TODO(philipel): Deprecate VCMPacketRequestCallback
164 // and use NackSender instead.
163 class VCMPacketRequestCallback { 165 class VCMPacketRequestCallback {
164 public: 166 public:
165 virtual int32_t ResendPackets(const uint16_t* sequenceNumbers, 167 virtual int32_t ResendPackets(const uint16_t* sequenceNumbers,
166 uint16_t length) = 0; 168 uint16_t length) = 0;
167 169
168 protected: 170 protected:
169 virtual ~VCMPacketRequestCallback() {} 171 virtual ~VCMPacketRequestCallback() {}
170 }; 172 };
171 173
174 class NackSender {
175 public:
176 virtual int32_t SendNack(const uint16_t* sequence_numbers,
177 uint16_t length) = 0;
stefan-webrtc 2016/03/01 12:16:34 length should probably be size_t. Maybe we could e
philipel 2016/03/01 13:31:08 Agree, the vector is much cleaner, fixed.
178
179 protected:
180 virtual ~NackSender() {}
181 };
182
183 class KeyFrameRequestSender {
184 public:
185 virtual int32_t RequestKeyFrame() = 0;
stefan-webrtc 2016/03/01 12:16:34 Return bool instead, or maybe even void? Same for
philipel 2016/03/01 13:31:08 Done.
186
187 protected:
188 virtual ~KeyFrameRequestSender() {}
189 };
190
172 // Callback used to inform the user of the the desired resolution 191 // Callback used to inform the user of the the desired resolution
173 // as subscribed by Media Optimization (Quality Modes) 192 // as subscribed by Media Optimization (Quality Modes)
174 class VCMQMSettingsCallback { 193 class VCMQMSettingsCallback {
175 public: 194 public:
176 virtual int32_t SetVideoQMSettings(const uint32_t frameRate, 195 virtual int32_t SetVideoQMSettings(const uint32_t frameRate,
177 const uint32_t width, 196 const uint32_t width,
178 const uint32_t height) = 0; 197 const uint32_t height) = 0;
179 198
180 virtual void SetTargetFramerate(int frame_rate) = 0; 199 virtual void SetTargetFramerate(int frame_rate) = 0;
181 200
182 protected: 201 protected:
183 virtual ~VCMQMSettingsCallback() {} 202 virtual ~VCMQMSettingsCallback() {}
184 }; 203 };
185 204
186 // Callback class used for telling the user about the size (in time) of the 205 // Callback class used for telling the user about the size (in time) of the
187 // render buffer, that is the size in time of the complete continuous frames. 206 // render buffer, that is the size in time of the complete continuous frames.
188 class VCMRenderBufferSizeCallback { 207 class VCMRenderBufferSizeCallback {
189 public: 208 public:
190 virtual void RenderBufferSizeMs(int buffer_size_ms) = 0; 209 virtual void RenderBufferSizeMs(int buffer_size_ms) = 0;
191 210
192 protected: 211 protected:
193 virtual ~VCMRenderBufferSizeCallback() {} 212 virtual ~VCMRenderBufferSizeCallback() {}
194 }; 213 };
195 214
196 } // namespace webrtc 215 } // namespace webrtc
197 216
198 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_DEFINES_H_ 217 #endif // WEBRTC_MODULES_VIDEO_CODING_INCLUDE_VIDEO_CODING_DEFINES_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698