Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: PRESUBMIT.py

Issue 1715043002: Remove webrtc/sound/ subdir. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@remove_devicemanager
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/build/merge_libs.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import json 9 import json
10 import os 10 import os
11 import platform 11 import platform
12 import re 12 import re
13 import subprocess 13 import subprocess
14 import sys 14 import sys
15 15
16 16
17 # Directories that will be scanned by cpplint by the presubmit script. 17 # Directories that will be scanned by cpplint by the presubmit script.
18 CPPLINT_DIRS = [ 18 CPPLINT_DIRS = [
19 'webrtc/audio', 19 'webrtc/audio',
20 'webrtc/call', 20 'webrtc/call',
21 'webrtc/common_video', 21 'webrtc/common_video',
22 'webrtc/examples', 22 'webrtc/examples',
23 'webrtc/modules/bitrate_controller', 23 'webrtc/modules/bitrate_controller',
24 'webrtc/modules/congestion_controller', 24 'webrtc/modules/congestion_controller',
25 'webrtc/modules/pacing', 25 'webrtc/modules/pacing',
26 'webrtc/modules/remote_bitrate_estimator', 26 'webrtc/modules/remote_bitrate_estimator',
27 'webrtc/modules/rtp_rtcp', 27 'webrtc/modules/rtp_rtcp',
28 'webrtc/modules/video_coding', 28 'webrtc/modules/video_coding',
29 'webrtc/modules/video_processing', 29 'webrtc/modules/video_processing',
30 'webrtc/sound',
31 'webrtc/tools', 30 'webrtc/tools',
32 'webrtc/video', 31 'webrtc/video',
33 ] 32 ]
34 33
35 # These filters will always be removed, even if the caller specifies a filter 34 # These filters will always be removed, even if the caller specifies a filter
36 # set, as they are problematic or broken in some way. 35 # set, as they are problematic or broken in some way.
37 # 36 #
38 # Justifications for each filter: 37 # Justifications for each filter:
39 # - build/c++11 : Rvalue ref checks are unreliable (false positives), 38 # - build/c++11 : Rvalue ref checks are unreliable (false positives),
40 # include file and feature blacklists are 39 # include file and feature blacklists are
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
219 return result 218 return result
220 219
221 def _CheckNoRtcBaseDeps(input_api, gyp_files, output_api): 220 def _CheckNoRtcBaseDeps(input_api, gyp_files, output_api):
222 pattern = input_api.re.compile(r"base.gyp:rtc_base\s*'") 221 pattern = input_api.re.compile(r"base.gyp:rtc_base\s*'")
223 violating_files = [] 222 violating_files = []
224 for f in gyp_files: 223 for f in gyp_files:
225 gyp_exceptions = ( 224 gyp_exceptions = (
226 'base_tests.gyp', 225 'base_tests.gyp',
227 'desktop_capture.gypi', 226 'desktop_capture.gypi',
228 'p2p.gyp', 227 'p2p.gyp',
229 'sound.gyp',
230 'webrtc_test_common.gyp', 228 'webrtc_test_common.gyp',
231 'webrtc_tests.gypi', 229 'webrtc_tests.gypi',
232 ) 230 )
233 if f.LocalPath().endswith(gyp_exceptions): 231 if f.LocalPath().endswith(gyp_exceptions):
234 continue 232 continue
235 contents = input_api.ReadFile(f) 233 contents = input_api.ReadFile(f)
236 if pattern.search(contents): 234 if pattern.search(contents):
237 violating_files.append(f) 235 violating_files.append(f)
238 if violating_files: 236 if violating_files:
239 return [output_api.PresubmitError( 237 return [output_api.PresubmitError(
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
512 for builder in masters[master]: 510 for builder in masters[master]:
513 if 'presubmit' in builder: 511 if 'presubmit' in builder:
514 # Do not trigger presubmit builders, since they're likely to fail 512 # Do not trigger presubmit builders, since they're likely to fail
515 # (e.g. OWNERS checks before finished code review), and we're running 513 # (e.g. OWNERS checks before finished code review), and we're running
516 # local presubmit anyway. 514 # local presubmit anyway.
517 pass 515 pass
518 else: 516 else:
519 try_config[master][builder] = ['defaulttests'] 517 try_config[master][builder] = ['defaulttests']
520 518
521 return try_config 519 return try_config
OLDNEW
« no previous file with comments | « no previous file | webrtc/build/merge_libs.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698