Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1714843003: Removing some redundant ostringstreams declarations. (Closed)

Created:
4 years, 10 months ago by Taylor Brandstetter
Modified:
4 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Removing some redundant ostringstreams declarations. These shadow a variable in an exterior scope, and cause unneeded overhead. R=pthatcher@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/9788534c77caa21a25027247d86fa5d41d47ebfe

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M webrtc/api/webrtcsdp.cc View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Taylor Brandstetter
4 years, 10 months ago (2016-02-19 21:19:57 UTC) #2
pthatcher1
lgtm
4 years, 10 months ago (2016-02-20 08:33:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1714843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1714843003/1
4 years, 10 months ago (2016-02-22 20:07:48 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/5316) ios_arm64_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 10 months ago (2016-02-22 20:11:10 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9788534c77caa21a25027247d86fa5d41d47ebfe Cr-Commit-Position: refs/heads/master@{#11725}
4 years, 10 months ago (2016-02-23 20:58:27 UTC) #10
Taylor Brandstetter
4 years, 10 months ago (2016-02-23 20:58:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9788534c77caa21a25027247d86fa5d41d47ebfe (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698