Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(927)

Unified Diff: webrtc/pc/mediasession.cc

Issue 1713493003: Enabling rtcp-rsize negotiation and fixing some issues with it. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Fixing unit test and adding more TODOs. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc ('k') | webrtc/video/video_send_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/mediasession.cc
diff --git a/webrtc/pc/mediasession.cc b/webrtc/pc/mediasession.cc
index 6a98f7d07681d2a2c0c2d19f1c969595487f8883..a9d1b95c22aee6aae9299315a9ecc05586242336 100644
--- a/webrtc/pc/mediasession.cc
+++ b/webrtc/pc/mediasession.cc
@@ -755,11 +755,9 @@ static bool CreateMediaContentOffer(
offer->set_crypto_required(CT_SDES);
}
offer->set_rtcp_mux(options.rtcp_mux_enabled);
- // TODO(deadbeef): Once we're sure this works correctly, enable it in
- // CreateOffer.
- // if (offer->type() == cricket::MEDIA_TYPE_VIDEO) {
- // offer->set_rtcp_reduced_size(true);
- // }
+ if (offer->type() == cricket::MEDIA_TYPE_VIDEO) {
+ offer->set_rtcp_reduced_size(true);
+ }
offer->set_multistream(options.is_muc);
offer->set_rtp_header_extensions(rtp_extensions);
@@ -1053,11 +1051,9 @@ static bool CreateMediaContentAnswer(
answer->set_rtp_header_extensions(negotiated_rtp_extensions);
answer->set_rtcp_mux(options.rtcp_mux_enabled && offer->rtcp_mux());
- // TODO(deadbeef): Once we're sure this works correctly, enable it in
- // CreateAnswer.
- // if (answer->type() == cricket::MEDIA_TYPE_VIDEO) {
- // answer->set_rtcp_reduced_size(offer->rtcp_reduced_size());
- // }
+ if (answer->type() == cricket::MEDIA_TYPE_VIDEO) {
+ answer->set_rtcp_reduced_size(offer->rtcp_reduced_size());
+ }
if (sdes_policy != SEC_DISABLED) {
CryptoParams crypto;
« no previous file with comments | « webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.cc ('k') | webrtc/video/video_send_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698