webrtc/media/engine/webrtcvideoengine2.h - Issue 1713493003: Enabling rtcp-rsize negotiation and fixing some issues with it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/media/engine/webrtcvideoengine2.h

Issue 1713493003: Enabling rtcp-rsize negotiation and fixing some issues with it. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webrtc/media/engine/webrtcvideoengine2.h

diff --git a/webrtc/media/engine/webrtcvideoengine2.h b/webrtc/media/engine/webrtcvideoengine2.h

index 91a92bff5fc5a16ecbd8e92aa6d5addbeddb6bed..abbe0d5b0832eb4ce434cea2aa0695dacb33b6e6 100644

--- a/webrtc/media/engine/webrtcvideoengine2.h

+++ b/webrtc/media/engine/webrtcvideoengine2.h

@@ -201,7 +201,6 @@ class WebRtcVideoChannel2 : public VideoMediaChannel,

// These optionals are unset if not changed.

rtc::Optional<std::vector<VideoCodecSettings>> codec_settings;

rtc::Optional<std::vector<webrtc::RtpExtension>> rtp_header_extensions;

- rtc::Optional<webrtc::RtcpMode> rtcp_mode;

};

bool GetChangedSendParameters(const VideoSendParameters& params,

@@ -392,7 +391,8 @@ class WebRtcVideoChannel2 : public VideoMediaChannel,

void SetLocalSsrc(uint32_t local_ssrc);

void SetFeedbackParameters(bool nack_enabled,

bool remb_enabled,

- bool transport_cc_enabled);

+ bool transport_cc_enabled,

+ webrtc::RtcpMode rtcp_mode);

void SetRecvParameters(const ChangedRecvParameters& recv_params);

void RenderFrame(const webrtc::VideoFrame& frame,

« no previous file with comments | « no previous file | webrtc/media/engine/webrtcvideoengine2.cc » ('j') | webrtc/media/engine/webrtcvideoengine2.cc » ('J')