Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 10 months ago by kjellander_webrtc Modified:
4 years, 10 months ago Reviewers:
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc Base URL:
https://chromium.googlesource.com/external/webrtc@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRoll chromium_revision 1d144ca..fa5d546 (375480:376142)
* Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0
(see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/common.gypi)
* Fix errors that will fail when MSVS 2015 is rolled in (coming soon).
* Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed.
Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546
Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546
Changed dependencies:
* src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4
* src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce
DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS
No update to Clang.
TBR=
BUG=webrtc:5549
NOTRY=True
Committed: https://crrev.com/66a99283be575f967bd92144e5161ff42fa948b8
Cr-Commit-Position: refs/heads/master@{#11673}
Patch Set 1 #Patch Set 2 : A collection of fixes #
Created: 4 years, 10 months ago
Messages
Total messages: 18 (12 generated)
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713493002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_gn_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/7127)
Description was changed from ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= ========== to ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (hasn't happened yet). * Move over to using sysroot for building on Linux. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= ==========
Description was changed from ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (hasn't happened yet). * Move over to using sysroot for building on Linux. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= ========== to ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (hasn't happened yet). * Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= ==========
Description was changed from ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (hasn't happened yet). * Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= ========== to ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (hasn't happened yet). * Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= BUG=webrtc:5549 ==========
Description was changed from ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (hasn't happened yet). * Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= BUG=webrtc:5549 ========== to ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (hasn't happened yet). * Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= BUG=webrtc:5549 ==========
Description was changed from ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (hasn't happened yet). * Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= BUG=webrtc:5549 ========== to ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (coming soon). * Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= BUG=webrtc:5549 ==========
Description was changed from ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (coming soon). * Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= BUG=webrtc:5549 ========== to ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (coming soon). * Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= BUG=webrtc:5549 NOTRY=True ==========
The CQ bit was checked by kjellander@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1713493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1713493002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/3527)
Description was changed from ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (coming soon). * Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= BUG=webrtc:5549 NOTRY=True ========== to ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (coming soon). * Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= BUG=webrtc:5549 NOTRY=True Committed: https://chromium.googlesource.com/external/webrtc/+/66a99283be575f967bd92144e... ==========
Message was sent while issue was closed.
Description was changed from ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (coming soon). * Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= BUG=webrtc:5549 NOTRY=True Committed: https://chromium.googlesource.com/external/webrtc/+/66a99283be575f967bd92144e... ========== to ========== Roll chromium_revision 1d144ca..fa5d546 (375480:376142) * Disable iOS warnings triggered by moving from ios_deployment_target 7.0 to 9.0 (see https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/build/commo...) * Fix errors that will fail when MSVS 2015 is rolled in (coming soon). * Start using sysroot for building on Linux since http://crbug.com/561584 has been fixed. Change log: https://chromium.googlesource.com/chromium/src/+log/1d144ca..fa5d546 Full diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546 Changed dependencies: * src/third_party/libyuv: https://chromium.googlesource.com/libyuv/libyuv.git/+log/903c91c..20343f4 * src/tools/gyp: https://chromium.googlesource.com/external/gyp.git/+log/2f9ffdc..ed163ce DEPS diff: https://chromium.googlesource.com/chromium/src/+/1d144ca..fa5d546/DEPS No update to Clang. TBR= BUG=webrtc:5549 NOTRY=True Committed: https://crrev.com/66a99283be575f967bd92144e5161ff42fa948b8 Cr-Commit-Position: refs/heads/master@{#11673} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/66a99283be575f967bd92144e5161ff42fa948b8 Cr-Commit-Position: refs/heads/master@{#11673}
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 66a99283be575f967bd92144e5161ff42fa948b8. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
