Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1712773003: Include "sharedexclusivelock.cc" in Chromium GN build. (Closed)

Created:
4 years, 10 months ago by joachim
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Include "sharedexclusivelock.cc" in Chromium GN build. Landing https://codereview.webrtc.org/1675923002/ broke some Chromium FYI bots because the GN build didn't include "sharedexclusivelock.cc" in that scenario. This CL moves the files from the non-Chromium block into the common sources list. BUG=webrtc:5496 Committed: https://crrev.com/a18f638ab1625e8360abbf51bf2082f056f39e09 Cr-Commit-Position: refs/heads/master@{#11699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
joachim
Ptal Is there a way to run the Chromium FYI trybots before submitting a CL ...
4 years, 10 months ago (2016-02-19 16:12:23 UTC) #2
tommi
lgtm Thanks for fixing
4 years, 10 months ago (2016-02-21 08:53:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712773003/1
4 years, 10 months ago (2016-02-21 08:53:29 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-21 09:56:20 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a18f638ab1625e8360abbf51bf2082f056f39e09 Cr-Commit-Position: refs/heads/master@{#11699}
4 years, 10 months ago (2016-02-21 09:56:30 UTC) #9
kjellander_webrtc
4 years, 10 months ago (2016-02-22 04:34:23 UTC) #10
Message was sent while issue was closed.
lgtm, sorry for that we still have inconsistencies between the GYP and GN build.
We're all looking forward to switching to GN-only in the future.

Powered by Google App Engine
This is Rietveld 408576698