Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2417)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1712513002: Replace scoped_ptr with unique_ptr in webrtc/common_audio/ (Closed)

Created:
4 years, 10 months ago by kwiberg-webrtc
Modified:
4 years, 10 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace scoped_ptr with unique_ptr in webrtc/common_audio/ BUG=webrtc:5520 Committed: https://crrev.com/79d7a499c0c3e1de8f5ad1138236f0386701053f Cr-Commit-Position: refs/heads/master@{#11716}

Patch Set 1 #

Patch Set 2 : need uintptr_t #

Total comments: 2

Patch Set 3 : remove unnecessary include #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -95 lines) Patch
M webrtc/common_audio/audio_converter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/common_audio/audio_converter.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/audio_converter_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/audio_ring_buffer.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/common_audio/audio_ring_buffer_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/common_audio/blocker.h View 2 chunks +3 lines, -2 lines 0 comments Download
M webrtc/common_audio/blocker_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/common_audio/channel_buffer.h View 2 chunks +5 lines, -4 lines 0 comments Download
M webrtc/common_audio/channel_buffer.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M webrtc/common_audio/fir_filter.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/common_audio/fir_filter_neon.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/common_audio/fir_filter_sse.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/common_audio/fir_filter_sse.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_audio/fir_filter_unittest.cc View 11 chunks +12 lines, -11 lines 0 comments Download
M webrtc/common_audio/include/audio_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_audio/lapped_transform.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/common_audio/real_fourier.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/common_audio/real_fourier.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/real_fourier_ooura.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/common_audio/real_fourier_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/common_audio/resampler/include/push_resampler.h View 2 chunks +8 lines, -7 lines 0 comments Download
M webrtc/common_audio/resampler/push_sinc_resampler.h View 2 chunks +4 lines, -3 lines 0 comments Download
M webrtc/common_audio/resampler/push_sinc_resampler_unittest.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M webrtc/common_audio/resampler/sinc_resampler.h View 2 chunks +6 lines, -5 lines 0 comments Download
M webrtc/common_audio/resampler/sinc_resampler_unittest.cc View 5 chunks +7 lines, -6 lines 0 comments Download
M webrtc/common_audio/ring_buffer_unittest.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M webrtc/common_audio/sparse_fir_filter_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/audio_processing/transient/transient_suppressor.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712513002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712513002/20001
4 years, 10 months ago (2016-02-18 17:34:32 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11026)
4 years, 10 months ago (2016-02-18 17:44:19 UTC) #4
kwiberg-webrtc
4 years, 10 months ago (2016-02-18 17:53:51 UTC) #6
hlundin-webrtc
LGTM with one nit. https://codereview.webrtc.org/1712513002/diff/20001/webrtc/common_audio/vad/vad.cc File webrtc/common_audio/vad/vad.cc (right): https://codereview.webrtc.org/1712513002/diff/20001/webrtc/common_audio/vad/vad.cc#newcode11 webrtc/common_audio/vad/vad.cc:11: #include <memory> memory is already ...
4 years, 10 months ago (2016-02-22 08:55:17 UTC) #7
kwiberg-webrtc
https://codereview.webrtc.org/1712513002/diff/20001/webrtc/common_audio/vad/vad.cc File webrtc/common_audio/vad/vad.cc (right): https://codereview.webrtc.org/1712513002/diff/20001/webrtc/common_audio/vad/vad.cc#newcode11 webrtc/common_audio/vad/vad.cc:11: #include <memory> On 2016/02/22 08:55:17, hlundin-webrtc wrote: > memory ...
4 years, 10 months ago (2016-02-22 14:06:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712513002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712513002/60001
4 years, 10 months ago (2016-02-22 18:11:55 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: ios64_sim_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/5310) ios_arm64_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 10 months ago (2016-02-22 18:13:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1712513002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1712513002/60001
4 years, 10 months ago (2016-02-23 09:13:49 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 10 months ago (2016-02-23 09:26:48 UTC) #16
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/79d7a499c0c3e1de8f5ad1138236f0386701053f Cr-Commit-Position: refs/heads/master@{#11716}
4 years, 10 months ago (2016-02-23 09:27:00 UTC) #18
kjellander_webrtc
4 years, 10 months ago (2016-02-23 21:32:58 UTC) #19
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.webrtc.org/1726043002/ by kjellander@webrtc.org.

The reason for reverting is: Breaks downstream compilation using
webrtc/common_audio/real_fourier.h. Let's chat tomorrow on how to coordinate a
re-land..

Powered by Google App Engine
This is Rietveld 408576698