webrtc/video/video_send_stream.cc - Issue 1711763003: New flag is_screencast in VideoOptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/video_send_stream.cc

Issue 1711763003: New flag is_screencast in VideoOptions. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Rebase, on top of suspend_below_min_bitrate change. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/video/video_send_stream.cc

diff --git a/webrtc/video/video_send_stream.cc b/webrtc/video/video_send_stream.cc

index 798b494fdb78a93bafc06f69529a2fcd3c9d8111..241a0de34563d06111d804d1bd88d64654c3b494 100644

--- a/webrtc/video/video_send_stream.cc

+++ b/webrtc/video/video_send_stream.cc

@@ -475,9 +475,12 @@ bool VideoSendStream::ReconfigureVideoEncoder(

RTC_DCHECK_GT(streams[0].max_framerate, 0);

video_codec.maxFramerate = streams[0].max_framerate;

- if (!SetSendCodec(video_codec))

+ if (!SetSendCodec(video_codec)) {

+ LOG(LS_WARNING) << "(Re)configureVideoEncoder: SetSendCodec failed "

nisse-webrtc 2016/03/01 13:24:40 I moved failure logging down here, at pbos' sugges

+ "for config: "

+ << config.ToString();

return false;

+ }

// Clear stats for disabled layers.

for (size_t i = video_codec.numberOfSimulcastStreams;

i < config_.rtp.ssrcs.size(); ++i) {