webrtc::RtpPacket name freed for better RtpPacket

webrtc::RtpPacket name freed for better RtpPacket

There were two different structures named RtpPacket in webrtc namespace:
RtpPacket defined in fec_test_helper renamed to test::RawRtpPacket
RtpPacket defined in rtp_sender_video and producer_fec removed as unused

BUG=webrtc:5261
R=sprang@google.com, stefan@webrtc.org

Committed: https://crrev.com/1e80ce438eefab6394fb176fdcb8938a13dda16c
Cr-Commit-Position: refs/heads/master@{#11682}

[danilchap, 2016-02-19 13:27:46]

Description was changed from

==========
webrtc::RtpPacket name freed for better RtpPacket

There were two different structures named RtpPacket in webrtc namespace:
RtpPacket defined in fec_test_helper renamed to FecRtpPacket
RtpPacket defined in rtp_sender_video and producer_fec removed as unused

BUG=webrtc:5261
==========

to

==========
webrtc::RtpPacket name freed for better RtpPacket

There were two different structures named RtpPacket in webrtc namespace:
RtpPacket defined in fec_test_helper renamed to FecRtpPacket
RtpPacket defined in rtp_sender_video and producer_fec removed as unused

BUG=webrtc:5261
==========

[danilchap, 2016-02-19 13:27:46]

danilchap@webrtc.org changed reviewers:
+ sprang@webrtc.org, stefan@webrtc.org

[sprang, 2016-02-19 13:55:58]

sprang@google.com changed reviewers:
+ sprang@google.com

[sprang, 2016-02-19 13:55:59]

lgtm

[stefan-webrtc, 2016-02-19 14:21:16]

https://codereview.webrtc.org/1710103004/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/fec_test_helper.h (right):

https://codereview.webrtc.org/1710103004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/fec_test_helper.h:23: struct FecRtpPacket :
public ForwardErrorCorrection::Packet {
Could you define this within the test namespace instead? Now it sounds like this
is a packet containing fec data, which it's not.

[danilchap, 2016-02-19 14:48:29]

https://codereview.webrtc.org/1710103004/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/fec_test_helper.h (right):

https://codereview.webrtc.org/1710103004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/fec_test_helper.h:23: struct FecRtpPacket :
public ForwardErrorCorrection::Packet {
On 2016/02/19 14:21:15, stefan-webrtc (holmer) wrote:
> Could you define this within the test namespace instead? Now it sounds like
this
> is a packet containing fec data, which it's not. 

checked what it containing and renamed to test::RawRtpPacket.

[danilchap, 2016-02-19 14:48:45]

Description was changed from

==========
webrtc::RtpPacket name freed for better RtpPacket

There were two different structures named RtpPacket in webrtc namespace:
RtpPacket defined in fec_test_helper renamed to FecRtpPacket
RtpPacket defined in rtp_sender_video and producer_fec removed as unused

BUG=webrtc:5261
==========

to

==========
webrtc::RtpPacket name freed for better RtpPacket

There were two different structures named RtpPacket in webrtc namespace:
RtpPacket defined in fec_test_helper renamed to test::RawRtpPacket
RtpPacket defined in rtp_sender_video and producer_fec removed as unused

BUG=webrtc:5261
==========

[stefan-webrtc, 2016-02-19 14:56:21]

lgtm

https://codereview.webrtc.org/1710103004/diff/1/webrtc/modules/rtp_rtcp/sourc...
File webrtc/modules/rtp_rtcp/source/fec_test_helper.h (right):

https://codereview.webrtc.org/1710103004/diff/1/webrtc/modules/rtp_rtcp/sourc...
webrtc/modules/rtp_rtcp/source/fec_test_helper.h:23: struct FecRtpPacket :
public ForwardErrorCorrection::Packet {
On 2016/02/19 14:48:29, danilchap wrote:
> On 2016/02/19 14:21:15, stefan-webrtc (holmer) wrote:
> > Could you define this within the test namespace instead? Now it sounds like
> this
> > is a packet containing fec data, which it's not. 
> 
> checked what it containing and renamed to test::RawRtpPacket.

Ok. test::RtpPacket would work too I guess? Doesn't really matter, but shorter.

[danilchap, 2016-02-19 15:02:28]

Description was changed from

==========
webrtc::RtpPacket name freed for better RtpPacket

There were two different structures named RtpPacket in webrtc namespace:
RtpPacket defined in fec_test_helper renamed to test::RawRtpPacket
RtpPacket defined in rtp_sender_video and producer_fec removed as unused

BUG=webrtc:5261
==========

to

==========
webrtc::RtpPacket name freed for better RtpPacket

There were two different structures named RtpPacket in webrtc namespace:
RtpPacket defined in fec_test_helper renamed to test::RawRtpPacket
RtpPacket defined in rtp_sender_video and producer_fec removed as unused

BUG=webrtc:5261
R=sprang@google.com, stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/1e80ce438eefab6394fb176fd...
==========

[danilchap, 2016-02-19 15:02:29]

Committed patchset #2 (id:20001) manually as
1e80ce438eefab6394fb176fdcb8938a13dda16c (presubmit successful).

[commit-bot: I haz the power, 2016-02-19 15:02:30]

Description was changed from

==========
webrtc::RtpPacket name freed for better RtpPacket

There were two different structures named RtpPacket in webrtc namespace:
RtpPacket defined in fec_test_helper renamed to test::RawRtpPacket
RtpPacket defined in rtp_sender_video and producer_fec removed as unused

BUG=webrtc:5261
R=sprang@google.com, stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/1e80ce438eefab6394fb176fd...
==========

to

==========
webrtc::RtpPacket name freed for better RtpPacket

There were two different structures named RtpPacket in webrtc namespace:
RtpPacket defined in fec_test_helper renamed to test::RawRtpPacket
RtpPacket defined in rtp_sender_video and producer_fec removed as unused

BUG=webrtc:5261
R=sprang@google.com, stefan@webrtc.org

Committed: https://crrev.com/1e80ce438eefab6394fb176fdcb8938a13dda16c
Cr-Commit-Position: refs/heads/master@{#11682}
==========

[commit-bot: I haz the power, 2016-02-19 15:02:31]

Patchset 2 (id:??) landed as
https://crrev.com/1e80ce438eefab6394fb176fdcb8938a13dda16c
Cr-Commit-Position: refs/heads/master@{#11682}