Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1710083003: Fix Linux 32-bit compilation after sysroot switch. (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
niklase
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix Linux 32-bit compilation after sysroot switch. The roll in https://codereview.webrtc.org/1713493002/ made us start using the Chromium sysroot images for libraries instead of system libraries. This caused Linux 32-bit builds to break with an error like this: ../../webrtc/examples/peerconnection/client/linux/main_wnd.cc:82:46: error: missing sentinel in function call [-Werror,-Wsentinel] "List Items", renderer, "text", 0, NULL); ^ , nullptr /usr/include/gtk-2.0/gtk/gtktreeviewcolumn.h:128:25: note: function has been explicitly marked sentinel here GtkTreeViewColumn *gtk_tree_view_column_new_with_attributes (const gchar *title, ^ 1 error generated. This CL suppresses this warning to green up the bots. TBR=niklase@webrtc.org Committed: https://crrev.com/235aaa7468831b67041148bd8af67a4d262b642c Cr-Commit-Position: refs/heads/master@{#11674}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M webrtc/webrtc_examples.gyp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kjellander_webrtc
Since it's just an example application, I don't think we need to file a bug ...
4 years, 10 months ago (2016-02-18 20:51:58 UTC) #2
kjellander_webrtc
Committed patchset #1 (id:1) manually as 235aaa7468831b67041148bd8af67a4d262b642c.
4 years, 10 months ago (2016-02-18 20:52:38 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 20:52:42 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/235aaa7468831b67041148bd8af67a4d262b642c
Cr-Commit-Position: refs/heads/master@{#11674}

Powered by Google App Engine
This is Rietveld 408576698