Add looping sound button to AppRTCDemo

Add looping sound button to AppRTCDemo

This exposes the issue where AVAudioPlayer will stop playing when the
VoiceProcessing I/O audio unit is initialized.

BUG=
R=haysc@webrtc.org, henrika@webrtc.org

Committed: https://crrev.com/615fabb661e0a8a3a76e0d135ba37876a7887d7a
Cr-Commit-Position: refs/heads/master@{#11750}

[tkchin_webrtc, 2016-02-19 01:27:02]

Description was changed from

==========
Add looping sound button to AppRTCDemo

This exposes the issue where AVAudioPlayer will stop playing when the
VoiceProcessing I/O audio unit is initialized.

BUG=
==========

to

==========
Add looping sound button to AppRTCDemo

This exposes the issue where AVAudioPlayer will stop playing when the
VoiceProcessing I/O audio unit is initialized.

BUG=
==========

[tkchin_webrtc, 2016-02-19 01:27:02]

tkchin@webrtc.org changed reviewers:
+ haysc@webrtc.org, henrika@webrtc.org

[tkchin_webrtc, 2016-02-19 01:28:21]

Precursor to allow testing the fix for the AVAudioPlayer issue. I haven't added
the mp3 yet because I still need to find a suitable one.

[henrika_webrtc, 2016-02-19 09:10:39]

Great that you add these parts to AppRTCDemo so we can all make simple tests.
Love the idea.

LGTM

FYI, some available MP3 files in Chrome (BTW, would it not be sufficient with a
WAV file):

./chromium/src/chrome/test/data/android/media/mpthreetest.mp3
./chromium/src/components/neterror/resources/sounds/button-press.mp3
./chromium/src/components/neterror/resources/sounds/hit.mp3
./chromium/src/components/neterror/resources/sounds/score-reached.mp3
./chromium/src/content/test/data/accessibility/html/sfx.mp3
./chromium/src/content/test/data/android/media/audio-1second.mp3
./chromium/src/content/test/data/android/media/audio-2seconds.mp3
./chromium/src/content/test/data/android/media/audio-6seconds.mp3
./chromium/src/media/test/data/bear-audio-10s-CBR-has-TOC.mp3
./chromium/src/media/test/data/bear-audio-10s-CBR-no-TOC.mp3
./chromium/src/media/test/data/bear-audio-10s-VBR-has-TOC.mp3
./chromium/src/media/test/data/bear-audio-10s-VBR-no-TOC.mp3
./chromium/src/media/test/data/corrupt.mp3
./chromium/src/media/test/data/icy_sfx.mp3
./chromium/src/media/test/data/id3_png_test.mp3
./chromium/src/media/test/data/id3_test.mp3
./chromium/src/media/test/data/midstream_config_change.mp3
./chromium/src/media/test/data/sfx.mp3
./chromium/src/third_party/catapult/third_party/gsutil/gslib/tests/test_data/test.mp3
./chromium/src/third_party/WebKit/LayoutTests/webaudio/resources/media/128kbps-44khz.mp3
./chromium/src/tools/android/audio_focus_grabber/java/res/raw/ping.mp3

[Chuck, 2016-02-19 14:41:20]

https://codereview.webrtc.org/1710053004/diff/1/webrtc/webrtc_examples.gyp
File webrtc/webrtc_examples.gyp (right):

https://codereview.webrtc.org/1710053004/diff/1/webrtc/webrtc_examples.gyp#ne...
webrtc/webrtc_examples.gyp:292:
'examples/objc/AppRTCDemo/ios/resources/outgoing_ring.mp3',
I don't see this file in the CL.

[tkchin_webrtc, 2016-02-19 18:27:27]

Patchset #2 (id:20001) has been deleted

[tkchin_webrtc, 2016-02-19 18:29:46]

PTAL

Yeah I hadn't found a good sound file yesterday, so I didn't attach an mp3 yet.
I ended up just making one last night.

[Chuck, 2016-02-22 16:48:46]

lgtm

[Chuck, 2016-02-22 16:48:46]

lgtm

[tkchin_webrtc, 2016-02-22 18:27:13]

The CQ bit was checked by tkchin@webrtc.org

[tkchin_webrtc, 2016-02-22 18:27:13]

The patchset sent to the CQ was uploaded after l-g-t-m from henrika@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1710053004/#ps40001 (title:
"Add mp3")

[commit-bot: I haz the power, 2016-02-22 18:27:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1710053004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1710053004/40001

[commit-bot: I haz the power, 2016-02-22 18:28:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-22 18:28:30]

Try jobs failed on following builders:
  ios64_sim_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios64_sim_dbg/builds/5312)
  ios_arm64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/7639)
  ios_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/7557)
  ios_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/11465)

[tkchin_webrtc, 2016-02-23 20:28:25]

tkchin@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[tkchin_webrtc, 2016-02-23 20:31:16]

kjellander@:
I started getting this warning for other targets in the gyp file:

Depending on rtc_base is not allowed. Change your dependency to
rtc_base_approved and possibly sanitize and move the desired source file(s) to
rtc_base_approved.
Changed GYP files:
  webrtc/webrtc_examples.gyp

What is the procedure for moving files into rtc_base_approved, and for this CL,
can I just land it manually since it will fail the presubmit step? (The
offending dependencies are in other targets in the file)

[kjellander_webrtc, 2016-02-23 22:09:51]

On 2016/02/23 20:31:16, tkchin_webrtc wrote:
> kjellander@:
> I started getting this warning for other targets in the gyp file:
> 
> Depending on rtc_base is not allowed. Change your dependency to
> rtc_base_approved and possibly sanitize and move the desired source file(s) to
> rtc_base_approved.
> Changed GYP files:
>   webrtc/webrtc_examples.gyp
> 
> What is the procedure for moving files into rtc_base_approved, and for this
CL,
> can I just land it manually since it will fail the presubmit step? (The
> offending dependencies are in other targets in the file)

See https://webrtc-codereview.appspot.com/22649004 for background on this
target. I'm not sure what we should do with it but there you get the point of
it.
I guess https://bugs.chromium.org/p/webrtc/issues/detail?id=3806 is still up for
grabs :)

[tkchin_webrtc, 2016-02-24 18:37:11]

On 2016/02/23 22:09:51, kjellander (webrtc) wrote:
> On 2016/02/23 20:31:16, tkchin_webrtc wrote:
> > kjellander@:
> > I started getting this warning for other targets in the gyp file:
> > 
> > Depending on rtc_base is not allowed. Change your dependency to
> > rtc_base_approved and possibly sanitize and move the desired source file(s)
to
> > rtc_base_approved.
> > Changed GYP files:
> >   webrtc/webrtc_examples.gyp
> > 
> > What is the procedure for moving files into rtc_base_approved, and for this
> CL,
> > can I just land it manually since it will fail the presubmit step? (The
> > offending dependencies are in other targets in the file)
> 
> See https://webrtc-codereview.appspot.com/22649004 for background on this
> target. I'm not sure what we should do with it but there you get the point of
> it.
> I guess https://bugs.chromium.org/p/webrtc/issues/detail?id=3806 is still up
for
> grabs :)

Gotcha. I'll land this for now and migrate the flags file (that
peerconnection_server needs) separately then.

[tkchin_webrtc, 2016-02-24 18:59:03]

Description was changed from

==========
Add looping sound button to AppRTCDemo

This exposes the issue where AVAudioPlayer will stop playing when the
VoiceProcessing I/O audio unit is initialized.

BUG=
==========

to

==========
Add looping sound button to AppRTCDemo

This exposes the issue where AVAudioPlayer will stop playing when the
VoiceProcessing I/O audio unit is initialized.

BUG=
R=haysc@webrtc.org, henrika@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/615fabb661e0a8a3a76e0d135...
==========

[tkchin_webrtc, 2016-02-24 18:59:04]

Committed patchset #4 (id:80001) manually as
615fabb661e0a8a3a76e0d135ba37876a7887d7a.

[commit-bot: I haz the power, 2016-02-24 18:59:07]

Description was changed from

==========
Add looping sound button to AppRTCDemo

This exposes the issue where AVAudioPlayer will stop playing when the
VoiceProcessing I/O audio unit is initialized.

BUG=
R=haysc@webrtc.org, henrika@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/615fabb661e0a8a3a76e0d135...
==========

to

==========
Add looping sound button to AppRTCDemo

This exposes the issue where AVAudioPlayer will stop playing when the
VoiceProcessing I/O audio unit is initialized.

BUG=
R=haysc@webrtc.org, henrika@webrtc.org

Committed: https://crrev.com/615fabb661e0a8a3a76e0d135ba37876a7887d7a
Cr-Commit-Position: refs/heads/master@{#11750}
==========

[commit-bot: I haz the power, 2016-02-24 18:59:08]

Patchset 4 (id:??) landed as
https://crrev.com/615fabb661e0a8a3a76e0d135ba37876a7887d7a
Cr-Commit-Position: refs/heads/master@{#11750}

[henrika_webrtc, 2016-02-25 09:00:29]

Love the music Zeke ;-)

FYI: tried it on iPhone 5C and can confirm that music stops when audio starts
streaming and music is not resumed when we hang up.
One must first stop the music and restart it to be able to hear the music again.