Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1709953002: Revert of Remove GetTransport() from TransportChannelImpl (Closed)

Created:
4 years, 10 months ago by guidou
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove GetTransport() from TransportChannelImpl (patchset #3 id:40001 of https://codereview.webrtc.org/1691673002/ ) Reason for revert: This CL is breaking a lot of FYI bots. The specific change that breaks bots is the removal of a constructor parameter. See, for example: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/3572/steps/compile/logs/stdio Original issue's description: > Remove GetTransport() from TransportChannelImpl > > This appears to be dead code because GetTransport() is not used by WebRTC. It also adds dead code to DtlsTransportChannelWrapper and P2PTransportChannel. > > BUG= > > Committed: https://crrev.com/ee18220ddd783fad9812f1c1c195bf187a631c3a > Cr-Commit-Position: refs/heads/master@{#11662} TBR=pthatcher@webrtc.org,mikescarlett@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/74db777d64d8d15b043c102bd5309755cf2106c2 Cr-Commit-Position: refs/heads/master@{#11665}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -22 lines) Patch
M webrtc/p2p/base/dtlstransport.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 3 chunks +7 lines, -2 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/base/faketransportcontroller.h View 4 chunks +7 lines, -2 lines 0 comments Download
M webrtc/p2p/base/p2ptransport.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.h View 3 chunks +4 lines, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 14 chunks +14 lines, -14 lines 0 comments Download
M webrtc/p2p/base/transportchannelimpl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/p2p/quic/quicsession_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
guidou
Created Revert of Remove GetTransport() from TransportChannelImpl
4 years, 10 months ago (2016-02-18 09:57:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709953002/1
4 years, 10 months ago (2016-02-18 09:57:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 09:57:53 UTC) #4
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 09:58:02 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74db777d64d8d15b043c102bd5309755cf2106c2
Cr-Commit-Position: refs/heads/master@{#11665}

Powered by Google App Engine
This is Rietveld 408576698