Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1123)

Issue 1709853002: Add RTCAudioSession proxy class. (Closed)

Created:
4 years, 10 months ago by tkchin_webrtc
Modified:
4 years, 10 months ago
Reviewers:
henrika_webrtc, Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add RTCAudioSession proxy class. BUG= R=haysc@webrtc.org, henrika@webrtc.org Committed: https://crrev.com/b3fb71c1011c5201b65787ff94c4c97c138c947e Cr-Commit-Position: refs/heads/master@{#11676}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+821 lines, -138 lines) Patch
M webrtc/modules/audio_device/BUILD.gn View 3 chunks +12 lines, -8 lines 0 comments Download
M webrtc/modules/audio_device/audio_device.gypi View 1 chunk +6 lines, -0 lines 0 comments Download
M webrtc/modules/audio_device/ios/audio_device_ios.mm View 11 chunks +87 lines, -130 lines 0 comments Download
A webrtc/modules/audio_device/ios/objc/RTCAudioSession.h View 1 chunk +153 lines, -0 lines 0 comments Download
A webrtc/modules/audio_device/ios/objc/RTCAudioSession.mm View 1 chunk +533 lines, -0 lines 0 comments Download
A webrtc/modules/audio_device/ios/objc/RTCAudioSession+Private.h View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (12 generated)
tkchin_webrtc
Splitting up the previous large CL. This one handles the proxy class + activation counts.
4 years, 10 months ago (2016-02-18 02:27:39 UTC) #5
henrika_webrtc
Looks great Zeke. I don't have any new comments. Looking forward to see this CL ...
4 years, 10 months ago (2016-02-18 13:58:10 UTC) #6
henrika_webrtc
Just checking that all unit tests and AppRTCDemo still works.
4 years, 10 months ago (2016-02-18 13:58:36 UTC) #7
Chuck
lgtm
4 years, 10 months ago (2016-02-18 15:45:31 UTC) #8
Chuck
lgtm
4 years, 10 months ago (2016-02-18 15:45:34 UTC) #9
tkchin_webrtc
On 2016/02/18 15:45:34, Chuck wrote: > lgtm Yup, unit tests pass and AppRTCDemo works. Thanks ...
4 years, 10 months ago (2016-02-18 19:28:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709853002/40001
4 years, 10 months ago (2016-02-18 19:28:57 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11032)
4 years, 10 months ago (2016-02-18 19:42:34 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709853002/40001
4 years, 10 months ago (2016-02-18 19:50:10 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11036)
4 years, 10 months ago (2016-02-18 20:04:27 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1709853002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1709853002/40001
4 years, 10 months ago (2016-02-18 23:28:37 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11041)
4 years, 10 months ago (2016-02-18 23:35:40 UTC) #22
tkchin_webrtc
Committed patchset #1 (id:40001) manually as b3fb71c1011c5201b65787ff94c4c97c138c947e (presubmit successful).
4 years, 10 months ago (2016-02-18 23:44:23 UTC) #25
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 23:44:23 UTC) #26
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b3fb71c1011c5201b65787ff94c4c97c138c947e
Cr-Commit-Position: refs/heads/master@{#11676}

Powered by Google App Engine
This is Rietveld 408576698