Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1709673003: Re-add RemoteBitrateEstimator::GetStats. (Closed)

Created:
4 years, 10 months ago by stefan-webrtc
Modified:
4 years, 10 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhuangzesen_agora.io, zhengzhonghou_agora.io, tterriberry_mozilla.com, andresp, the sun, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Re-add RemoteBitrateEstimator::GetStats. Will be kept around until implementations have been updated. This fixes build issues in dependent code caused by removing GetStats in https://chromium.googlesource.com/external/webrtc/+/62a5ccdb532cfa1256c3a5860bfe087569481d24 R=kjellander@webrtc.org Committed: https://crrev.com/59c634b605a906d292179bc5568469c030b9e9d0 Cr-Commit-Position: refs/heads/master@{#11664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M webrtc/modules/remote_bitrate_estimator/include/remote_bitrate_estimator.h View 2 chunks +8 lines, -0 lines 0 comments Download
M webrtc/video/vie_receiver.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
stefan-webrtc
4 years, 10 months ago (2016-02-18 08:14:45 UTC) #2
kjellander_webrtc
lgtm, but please run a few compile trybots before landing
4 years, 10 months ago (2016-02-18 08:41:02 UTC) #4
stefan-webrtc
Committed patchset #1 (id:1) manually as 59c634b605a906d292179bc5568469c030b9e9d0 (presubmit successful).
4 years, 10 months ago (2016-02-18 09:15:00 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 09:15:03 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/59c634b605a906d292179bc5568469c030b9e9d0
Cr-Commit-Position: refs/heads/master@{#11664}

Powered by Google App Engine
This is Rietveld 408576698