Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1708353002: Drop support for playing output through aplay in intelligibility_proc (Closed)

Created:
4 years, 10 months ago by aluebs-webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, bjornv1
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Drop support for playing output through aplay in intelligibility_proc It was hardly used, making the code more complex than needed and caused problems on iOS because it uses system. BUG=webrtc:5549 R=kjellander@webrtc.org Committed: https://crrev.com/4458d09ee422e78f494fb30d65f63d6bc321dba6 Cr-Commit-Position: refs/heads/master@{#11677}

Patch Set 1 #

Patch Set 2 : Rebasing #

Patch Set 3 : Remove suppression for audio_processing_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -39 lines) Patch
M webrtc/modules/audio_processing/audio_processing_tests.gypi View 1 2 1 chunk +0 lines, -12 lines 0 comments Download
M webrtc/modules/audio_processing/intelligibility/test/intelligibility_proc.cc View 1 2 3 chunks +3 lines, -27 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
aluebs-webrtc
4 years, 10 months ago (2016-02-18 19:01:35 UTC) #2
kjellander_webrtc
lgtm, but I just landed https://codereview.webrtc.org/1713493002/ so please remove the suppression for webrtc/modules/audio_processing/audio_processing_tests.gypi as part ...
4 years, 10 months ago (2016-02-18 19:31:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1708353002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1708353002/40001
4 years, 10 months ago (2016-02-19 02:49:38 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/11048)
4 years, 10 months ago (2016-02-19 02:57:00 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/4458d09ee422e78f494fb30d65f63d6bc321dba6 Cr-Commit-Position: refs/heads/master@{#11677}
4 years, 10 months ago (2016-02-19 03:16:22 UTC) #11
aluebs-webrtc
Committed patchset #3 (id:40001) manually as 4458d09ee422e78f494fb30d65f63d6bc321dba6 (presubmit successful).
4 years, 10 months ago (2016-02-19 03:16:22 UTC) #12
hlundin-webrtc
4 years, 10 months ago (2016-02-22 12:17:04 UTC) #13
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698