Remove PacketRouter sender distinction.

Remove PacketRouter sender distinction.

Instead relies on SetSendingMediaStatus() to filter out receiving RTP
modules. This status is now set in VoiceEngine's SetSend() for senders
along with SetSendingStatus().

BUG=
R=solenberg@webrtc.org, stefan@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/3dd5d1d84af02f8cdd08ea4198aa5392cb3d906d

[pbos-webrtc, 2016-02-17 15:51:31]

PTAL

[pbos-webrtc, 2016-02-17 15:51:38]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-17 15:51:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1705763002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1705763002/1

[commit-bot: I haz the power, 2016-02-17 16:15:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-17 16:15:29]

Dry run: Try jobs failed on following builders:
  linux_baremetal on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_baremetal/builds/...)

[the sun, 2016-02-17 19:54:54]

Nice, a few nits.

https://codereview.webrtc.org/1705763002/diff/1/webrtc/modules/pacing/packet_...
File webrtc/modules/pacing/packet_router_unittest.cc (right):

https://codereview.webrtc.org/1705763002/diff/1/webrtc/modules/pacing/packet_...
webrtc/modules/pacing/packet_router_unittest.cc:177:
packet_router_->AddRtpModule(&rtp_1);
Should you set SendingMedia() on one of rtp_1, rtp_2?

https://codereview.webrtc.org/1705763002/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (left):

https://codereview.webrtc.org/1705763002/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:2618: const bool sender =
rtp_packet_sender_proxy_->HasPacketSender();
Remove HasPacketSender() from RtpPacketSenderProxy.

https://codereview.webrtc.org/1705763002/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (right):

https://codereview.webrtc.org/1705763002/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:858:
_rtpRtcpModule->SetSendingMediaStatus(false);
Now that both voe/vie channels set "sending media" to false by default, can we
instead change the default of sending_media_ in RTPSender?

[pbos-webrtc, 2016-02-18 13:09:42]

PTAL

https://codereview.webrtc.org/1705763002/diff/1/webrtc/modules/pacing/packet_...
File webrtc/modules/pacing/packet_router_unittest.cc (right):

https://codereview.webrtc.org/1705763002/diff/1/webrtc/modules/pacing/packet_...
webrtc/modules/pacing/packet_router_unittest.cc:177:
packet_router_->AddRtpModule(&rtp_1);
On 2016/02/17 19:54:54, the sun wrote:
> Should you set SendingMedia() on one of rtp_1, rtp_2?

Not necessary since SendFeedback doesn't require a send module. Adding a test
that requires a sending module.

https://codereview.webrtc.org/1705763002/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (left):

https://codereview.webrtc.org/1705763002/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:2618: const bool sender =
rtp_packet_sender_proxy_->HasPacketSender();
On 2016/02/17 19:54:54, the sun wrote:
> Remove HasPacketSender() from RtpPacketSenderProxy.

Done.

https://codereview.webrtc.org/1705763002/diff/1/webrtc/voice_engine/channel.cc
File webrtc/voice_engine/channel.cc (right):

https://codereview.webrtc.org/1705763002/diff/1/webrtc/voice_engine/channel.c...
webrtc/voice_engine/channel.cc:858:
_rtpRtcpModule->SetSendingMediaStatus(false);
On 2016/02/17 19:54:54, the sun wrote:
> Now that both voe/vie channels set "sending media" to false by default, can we
> instead change the default of sending_media_ in RTPSender?

Done.

[pbos-webrtc, 2016-02-18 13:09:44]

set sending_media_ to false by default + tests + feedback

[stefan-webrtc, 2016-02-18 13:26:05]

lgtm

[pbos-webrtc, 2016-02-18 13:29:44]

revert sending_media_ = false

[pbos-webrtc, 2016-02-18 13:32:05]

I reverted the sending_media_ = false part, since importing this change
elsewhere might require more refactoring and I'm not even sure it makes more
sense for it to be in a sendable state or not initially.

Since I'm not sure what makes most sense (from a module-creation perspective),
I'll prefer to leave it unchanged for now.

[the sun, 2016-02-18 14:54:15]

lgtm

[pbos-webrtc, 2016-02-25 15:57:03]

Description was changed from

==========
Remove PacketRouter sender distinction.

Instead relies on SetSendingMediaStatus() to filter out receiving RTP
modules. This status is now set in VoiceEngine's SetSend() for senders
along with SetSendingStatus().

BUG=
R=solenberg@webrtc.org, stefan@webrtc.org
==========

to

==========
Remove PacketRouter sender distinction.

Instead relies on SetSendingMediaStatus() to filter out receiving RTP
modules. This status is now set in VoiceEngine's SetSend() for senders
along with SetSendingStatus().

BUG=
R=solenberg@webrtc.org, stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/3dd5d1d84af02f8cdd08ea419...
==========

[commit-bot: I haz the power, 2016-02-25 15:57:03]

Description was changed from

==========
Remove PacketRouter sender distinction.

Instead relies on SetSendingMediaStatus() to filter out receiving RTP
modules. This status is now set in VoiceEngine's SetSend() for senders
along with SetSendingStatus().

BUG=
R=solenberg@webrtc.org, stefan@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/3dd5d1d84af02f8cdd08ea419...
==========

to

==========
Remove PacketRouter sender distinction.

Instead relies on SetSendingMediaStatus() to filter out receiving RTP
modules. This status is now set in VoiceEngine's SetSend() for senders
along with SetSendingStatus().

BUG=
R=solenberg@webrtc.org, stefan@webrtc.org

Committed: https://crrev.com/3dd5d1d84af02f8cdd08ea4198aa5392cb3d906d
Cr-Commit-Position: refs/heads/master@{#11768}
==========

[commit-bot: I haz the power, 2016-02-25 15:57:04]

Patchset 3 (id:??) landed as
https://crrev.com/3dd5d1d84af02f8cdd08ea4198aa5392cb3d906d
Cr-Commit-Position: refs/heads/master@{#11768}

[pbos-webrtc, 2016-02-25 15:57:04]

Committed patchset #3 (id:40001) manually as
3dd5d1d84af02f8cdd08ea4198aa5392cb3d906d (presubmit successful).