Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Issue 1705733002: iOS: Include legacy objc API in all.gyp + fix H264 libyuv dependency (Closed)

Created:
4 years, 10 months ago by kjellander_webrtc
Modified:
4 years, 10 months ago
Reviewers:
hbos, henrika_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

iOS: Include legacy objc API in all.gyp + fix H264 libyuv dependency The legacy objc API is not included in the GYP generation if include_tests=0. This causes problems downstream in some cases, so it's changed in this CL. The libyuv dependency needs to be possible to disable using the build_libyuv GYP variable. NOTRY=True Committed: https://crrev.com/28c99bc44a1362377d24bd927a7c9a90e12914cd Cr-Commit-Position: refs/heads/master@{#11652}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M all.gyp View 1 1 chunk +9 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/codecs/h264/h264.gypi View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kjellander_webrtc
4 years, 10 months ago (2016-02-17 12:29:16 UTC) #2
henrika_webrtc
LGTM
4 years, 10 months ago (2016-02-17 12:34:13 UTC) #3
hbos
lgtm
4 years, 10 months ago (2016-02-17 12:47:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705733002/20001
4 years, 10 months ago (2016-02-17 13:37:12 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-17 13:38:32 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 13:38:38 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/28c99bc44a1362377d24bd927a7c9a90e12914cd
Cr-Commit-Position: refs/heads/master@{#11652}

Powered by Google App Engine
This is Rietveld 408576698