Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1439)

Unified Diff: webrtc/base/base.gyp

Issue 1705513002: Compile rtc_base_objc for Mac. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/build/WebRTC-Prefix.pch » ('j') | webrtc/build/WebRTC-Prefix.pch » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/base.gyp
diff --git a/webrtc/base/base.gyp b/webrtc/base/base.gyp
index 23d8ffe1651343a881dc4d85c5dcf0f0e1cf93b3..4152448048647f5e64ac243db164613a492e8b98 100644
--- a/webrtc/base/base.gyp
+++ b/webrtc/base/base.gyp
@@ -22,13 +22,12 @@
}],
],
}],
- # TODO(tkchin): Mac support. There are a bunch of problems right now because
- # of some settings pulled down from Chromium.
- ['OS=="ios"', {
+ ['OS=="ios" or (OS=="mac" and mac_deployment_target=="10.7")', {
'targets': [
{
'target_name': 'rtc_base_objc',
'type': 'static_library',
+ 'includes': [ '../build/objc_common.gypi' ],
'dependencies': [
'rtc_base',
],
@@ -60,10 +59,6 @@
},
}],
],
- 'xcode_settings': {
- 'CLANG_ENABLE_OBJC_ARC': 'YES',
- 'CLANG_WARN_OBJC_MISSING_PROPERTY_SYNTHESIS': 'YES',
- },
}
],
}], # OS=="ios"
« no previous file with comments | « no previous file | webrtc/build/WebRTC-Prefix.pch » ('j') | webrtc/build/WebRTC-Prefix.pch » ('J')

Powered by Google App Engine
This is Rietveld 408576698