Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 1705513002: Compile rtc_base_objc for Mac. (Closed)

Created:
4 years, 10 months ago by tkchin_webrtc
Modified:
4 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Compile rtc_base_objc for Mac. BUG= Committed: https://crrev.com/ee75c7a78f7596e89156c9888ef78c05395f33b8 Cr-Commit-Position: refs/heads/master@{#11661}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : Update year. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -7 lines) Patch
M webrtc/base/base.gyp View 2 chunks +2 lines, -7 lines 0 comments Download
A webrtc/build/WebRTC-Prefix.pch View 1 1 chunk +34 lines, -0 lines 0 comments Download
A webrtc/build/objc_common.gypi View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
tkchin_webrtc
The mac bots choke on NS_ASSUME_NONNULL_BEGIN/END because those are only defined in the 10.10.3 SDK ...
4 years, 10 months ago (2016-02-16 22:26:25 UTC) #7
hjon_webrtc
On 2016/02/16 22:26:25, tkchin_webrtc wrote: > The mac bots choke on NS_ASSUME_NONNULL_BEGIN/END because those are ...
4 years, 10 months ago (2016-02-16 23:21:55 UTC) #8
kjellander_webrtc
lgtm with nit. I've filed http://crbug.com/587377 for upgrading the bots to Xcode 7.2. https://codereview.webrtc.org/1705513002/diff/80001/webrtc/build/WebRTC-Prefix.pch File ...
4 years, 10 months ago (2016-02-17 09:39:55 UTC) #9
tkchin_webrtc
On 2016/02/17 09:39:55, kjellander (webrtc) wrote: > lgtm with nit. > > I've filed http://crbug.com/587377 ...
4 years, 10 months ago (2016-02-17 19:30:29 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705513002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705513002/100001
4 years, 10 months ago (2016-02-17 19:30:37 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_baremetal on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 10 months ago (2016-02-17 21:31:10 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1705513002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1705513002/100001
4 years, 10 months ago (2016-02-17 21:51:02 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 10 months ago (2016-02-17 22:44:56 UTC) #19
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 22:45:06 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee75c7a78f7596e89156c9888ef78c05395f33b8
Cr-Commit-Position: refs/heads/master@{#11661}

Powered by Google App Engine
This is Rietveld 408576698